Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(load): add arrow endpoints #2200
base: dev
Are you sure you want to change the base?
feat(load): add arrow endpoints #2200
Changes from 28 commits
ad63883
62f1b1d
cc01641
d73c8de
998c04e
f4206fe
f8b0f8a
ebd2df4
9a3591a
fddf3b8
582aed0
72ec467
43a5e40
4e74852
c99cdb1
0a4e6f5
1b6dc2b
cae2930
1b86d9a
f45f065
6506459
213cbaf
7b5e0a0
37b7108
1ef1ff1
4a234e6
c0a82de
e91dc71
997803a
255b104
aff9c83
d63cb8e
a522a22
8fe2863
9d55b36
5df3960
09bc218
7e3b03a
6277ae0
5fd6880
feb957f
cb3d3f4
fe6acbd
3218843
77c99aa
fc6cd91
ec17de9
fb3d8e3
1d3ed2b
55cbd21
684c72b
8730487
657e030
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally speaking for the other matrices, what is your vision here ? For hydro for instance, we want to add the code inside the HydroManager or do we want to create a specific manager on the side ? I personally prefer the 1st option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to support arrow input, I don't think we will be able to use a pydantic model (LoadDTO), because they expect JSON, which cannot contain binary data.
So: if we want the same URL to support at the same time JSON and arrow, we will need to separate it in 2 functions I think, for example discriminated by the "accept-content" header.
In any case, I think the function which will accept arrow input will need to have something else than a pydantic model as its argument (bytes or something else, I did not look into fastapi support for binary input).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventually, we decided to only support Arrow format. I'll check to see what is best to handle binary inputs