refactor constraint construction #1627
Conversation
| @@ -126,6 +127,12 @@ class ConstraintNamer : public Namer | |||
| void BindingConstraintHour(unsigned int constraint, const std::string& name); | |||
| void BindingConstraintDay(unsigned int constraint, const std::string& name); | |||
| void BindingConstraintWeek(unsigned int constraint, const std::string& name); | |||
| void CsrFlowDissociation(unsigned int constraint, | |||
There was a problem hiding this comment.
class Namer :
all data members are public (changeable from outside), a though they should be protected
There was a problem hiding this comment.
it is a hell of review
#TODO 😈
Watermelon AI SummaryAI Summary deactivated by a-zakir GitHub PRs
No results found in Jira Tickets :( No results found in Confluence Docs :( No results found in Slack Threads :( No results found in Notion Pages :( No results found in Linear Tickets :( No results found in Asana Tasks :( Antares_Simulator is an open repo and Watermelon will serve it for free. |
* rename method * rename with respect to the default style * remove default parameters * fix * update * fix * ShortTermStorageLevel specific case * NTC fix * .
watermelon-copilot-for-code-review
bot
added
🚨 Don't Merge
and removed
👀 Take a deeper dive
labels
watermelon-copilot-for-code-review
bot
added
👀 Take a deeper dive
and removed
🚨 Don't Merge
labels
watermelon-copilot-for-code-review
bot
added
🚨 Don't Merge
and removed
👀 Take a deeper dive
labels
![watermelon-copilot-for-code-review[bot]](https://avatars.githubusercontent.com/in/327523?s=60&v=4){kind=small}
| @@ -0,0 +1,66 @@ | |||
| #include "CsrAreaBalance.h" | |||
There was a problem hiding this comment.
This PR contains console logs. Please review or remove them.
| @@ -0,0 +1,66 @@ | |||
| #include "CsrAreaBalance.h" | |||
There was a problem hiding this comment.
This PR contains console logs. Please review or remove them.
|
flomnes
dismissed stale reviews from guilpier-code and sylvlecl
Most remarks have been taken into account
follows #1617 #1607 #1234 #1605
this pr introduces the following new features: