Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print low level logs #719

Merged
merged 71 commits into from
Jan 4, 2024
Merged

print low level logs #719

merged 71 commits into from
Jan 4, 2024

Conversation

a-zakir
Copy link
Contributor

@a-zakir a-zakir commented Nov 20, 2023

see review and history in #723

@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 20, 2023
* @tbittar remarks

* split behaviour and data holders

* rename data header

* add "other time"

* align columns

* align headers and data

* fix master time

* add CUMULATIVE nb of sub-pblm

* add num of subproblem solved / iteration

* add "expert" option for logs

* update

* to fit terminal width

* add expert_logs option in python code

* update doc

* remove unused function
@a-zakir a-zakir changed the title Math log print low level logs Dec 12, 2023
@a-zakir a-zakir reopened this Dec 12, 2023
Copy link

watermelon-copilot-for-code-review bot commented Dec 12, 2023

Watermelon AI Summary

AI Summary deactivated by a-zakir

GitHub PRs

antares-xpansion is an open repo and Watermelon will serve it for free.
🍉🫶

Watermelon AI Summary

AI Summary deactivated by a-zakir

GitHub PRs

No results found in Jira Tickets :(

No results found in Confluence Docs :(

No results found in Slack Threads :(

No results found in Notion Pages :(

No results found in Linear Tickets :(

No results found in Asana Tasks :(

antares-xpansion is an open repo and Watermelon will serve it for free.
🍉🫶

src/cpp/benders/benders_core/BendersMathLogger.cpp Outdated Show resolved Hide resolved
@@ -207,7 +207,7 @@ void printXpressBanner(bool error) {
XPRSgetbanner(banner);

if (error) {
std::cerr << "Xpress banner :\n" << banner << "\n";
std::cout << "Xpress banner :\n" << banner << "\n";
Copy link
Contributor

@tbittar tbittar Jan 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but the if and else have the same code, either remove the if/else structure or correct the code as needed

@tbittar tbittar self-requested a review January 2, 2024 10:31
src/cpp/benders/logger/MathLogger.cpp Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

45 New issues
0 Security Hotspots
33.3% Coverage on New Code
0.5% Duplication on New Code

See analysis details on SonarCloud

@a-zakir a-zakir merged commit 32c263b into develop Jan 4, 2024
8 of 10 checks passed
@a-zakir a-zakir deleted the feature/low-level-logs branch January 4, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants