Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/install antares lib #1773

Merged
merged 62 commits into from
Feb 8, 2024
Merged

Feature/install antares lib #1773

merged 62 commits into from
Feb 8, 2024

Conversation

JasonMarechal25
Copy link
Contributor

@JasonMarechal25 JasonMarechal25 commented Nov 15, 2023 •
edited
Loading

  • Create a new lib: locator. Expose previously named "solver.cpp" file functions used to located files and binaries. It is mostly used in UI but also in some tools.
  • Add include tree and update CMakeLists and include path accordingly for several libraries, mainly in solver
  • Install antares includes with install target.

@JasonMarechal25 JasonMarechal25 marked this pull request as draft November 15, 2023 15:54
@JasonMarechal25 JasonMarechal25 force-pushed the feature/install_antares_lib branch 4 times, most recently from e47d0db to 9bbf063 Compare November 22, 2023 16:08
@JasonMarechal25 JasonMarechal25 changed the base branch from develop to feature/solver-lib November 22, 2023 16:09
@JasonMarechal25 JasonMarechal25 marked this pull request as ready for review November 23, 2023 08:20
@a-zakir
Copy link
Contributor

a-zakir commented Nov 28, 2023

Poc ?

@watermelon-copilot-for-code-review watermelon-copilot-for-code-review bot mentioned this pull request Dec 11, 2023
Merged
@JasonMarechal25 JasonMarechal25 force-pushed the feature/install_antares_lib branch from 20662c2 to d01e7e4 Compare December 11, 2023 15:40
@JasonMarechal25 JasonMarechal25 force-pushed the feature/solver-lib branch 2 times, most recently from 9c7720a to bd729f1 Compare December 11, 2023 17:04
@JasonMarechal25 JasonMarechal25 force-pushed the feature/install_antares_lib branch from d01e7e4 to 862515e Compare December 12, 2023 09:48
@JasonMarechal25
Copy link
Contributor Author

Poc ?

No.
What makes you think so ?

@JasonMarechal25 JasonMarechal25 force-pushed the feature/install_antares_lib branch from 862515e to f0d9ea7 Compare December 12, 2023 10:06
Base automatically changed from feature/solver-lib to develop December 12, 2023 16:21
@watermelon-copilot-for-code-review watermelon-copilot-for-code-review bot mentioned this pull request Dec 12, 2023
Merged
@JasonMarechal25 JasonMarechal25 force-pushed the feature/install_antares_lib branch 2 times, most recently from 7564d12 to 67a2d70 Compare December 13, 2023 15:19
This was referenced Dec 15, 2023
Merged
Merged
@JasonMarechal25 JasonMarechal25 force-pushed the feature/install_antares_lib branch from 67a2d70 to 040ca26 Compare December 18, 2023 13:43
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

16.9% Duplication on New Code (required ≤ 3%)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

This was referenced Dec 20, 2023
Merged
Merged
@JasonMarechal25 JasonMarechal25 force-pushed the feature/install_antares_lib branch from 6251e63 to 659aa07 Compare February 2, 2024 14:59
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
17.2% Duplication on New Code (required ≤ 3%)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@flomnes flomnes merged commit a88cfd4 into develop Feb 8, 2024
4 of 5 checks passed
@flomnes flomnes deleted the feature/install_antares_lib branch February 8, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flomnes flomnes flomnes approved these changes

@guilpier-code guilpier-code guilpier-code left review comments

@sylvlecl sylvlecl Awaiting requested review from sylvlecl

@payetvin payetvin Awaiting requested review from payetvin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Sprint 1
Development

Successfully merging this pull request may close these issues.
5 participants
@JasonMarechal25 @a-zakir @flomnes @guilpier-code @JasonMarechal