feat: switch to V2 API and implement supported_chain for broader network support
#156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
This pull request is considered stale because it has been open 30 days with no activity. Remove stale label, add a comment, or make a new commit, otherwise this PR will be closed in 5 days. |
|
required another release of ape for ApeWorX/ape#2380 |
bitwise-constructs
previously approved these changes
Nov 20, 2024
antazoey
changed the title
supports_chain() API for adhoc network supportsupported_chain for broader network support
bitwise-constructs
previously approved these changes
Nov 21, 2024
antazoey
commented
Nov 21, 2024
antazoey
force-pushed
the
feat/auto-adhoc
branch
from
a84929f
to
8309767
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Implement the API defined here ApeWorX/ape#2325
and use their provided API for getting the list
How I did it
use the API they document to get the list
How to verify it
then
Checklist