Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom networks work with explorer #2325

Merged
merged 6 commits into from
Oct 21, 2024

Conversation

antazoey
Copy link
Member

What I did

Makes it so if you are connecting to an adhoc URL:

ape console --network https://arbitrum-nova.publicnode.com

that it can detect if the etherscan explorer works with this network

How I did it

How to verify it

ape console --network https://arbitrum-nova.publicnode.com

then

In [1]: provider.network.explorer
Out[1]: Etherscan(name='etherscan', network=<ethereum:custom chain_id=42170>)

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

@antazoey
Copy link
Member Author

Would like some feedback on this approach before proceeding, but it seems to work! I just kinda wish explorer plugins yielded chain IDs instead of network names

@antazoey antazoey marked this pull request as ready for review October 19, 2024 15:12
fubuloubu
fubuloubu previously approved these changes Oct 19, 2024
@antazoey antazoey enabled auto-merge (squash) October 21, 2024 15:54
@antazoey antazoey merged commit 6d2944e into ApeWorX:main Oct 21, 2024
16 checks passed
@antazoey antazoey deleted the feat/auto-adhocnet-explorers branch October 21, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants