-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TelemetrySource to ExecutionRejectedException #2346
Add TelemetrySource to ExecutionRejectedException #2346
Conversation
92e3f2e
to
cd0b75c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2346 +/- ##
==========================================
+ Coverage 85.40% 85.43% +0.02%
==========================================
Files 313 313
Lines 7467 7482 +15
Branches 1125 1125
==========================================
+ Hits 6377 6392 +15
Misses 745 745
Partials 345 345
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1d98646
to
4244d2d
Compare
4244d2d
to
ef63b0b
Compare
LGTM, great job! How about to update our docs too in follow-up? |
@martincostello is this ok to merge? |
src/Polly.Core/CircuitBreaker/Controller/CircuitStateController.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Martin Costello <[email protected]>
Thanks for your contribution @peter-csala - the changes from this pull request have been published as part of version 8.5.0 📦, which is now available from NuGet.org 🚀 |
Pull Request
The issue or feature being addressed
#2345
Details on the issue fix or feature implementation
Done
TelemetrySource
property to theExecutionRejectedException
ResilienceStrategyTelemetry
with aUpdateTelemetrySource
methodTelemetrySource
on the thrown exceptionConfirm the following