-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: handle from/to addresses in multiview (mobile views) #924
refactor: handle from/to addresses in multiview (mobile views) #924
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hey @patricio0312rev one conflict appeared after merging the accent color removal. |
@samharperpittam should be ready now 🌟 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These all read Value (ARK)
now instead of Amount (ARK)
. Can you check if it's the same for you please?
@samharperpittam sorry, got confused by the mockup, should be fixed now 🌟 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patricio0312rev - last change request from me. In Multiwallet view, the "Amount" value shouldn't have the green/yellow/grey background and the text should be black.
@samharperpittam yup, no worries my man, that's part of #930 |
[portfolio] handle from/to addresses in multi-view
Summary
TransactionRow
andTransactionRowMobile
components have been refactored to support thehideSender
prop, which activates/deactivates the advanced mode of theaddressing
column.TransactionRowAddressing
has been refactored to supportvariant
andisAdvanced
props. When the user has selected more than 1 wallet, the advanced mode of the addressing column activates and two of these components will render, the first always for thesender
and the second one always for therecipient
.TransactionRowAddressing
has been refactored and subdivided into child components for better readability and reduce the complexity when working with this component.Value
header has been renamedAmount
to match the designs.Screenshots
Checklist