Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: handle from/to addresses in multiview (mobile views) #924

Merged

Conversation

patricio0312rev
Copy link
Contributor

@patricio0312rev patricio0312rev commented Jan 29, 2025

[portfolio] handle from/to addresses in multi-view

Summary

  • This first part is only focused on 320px, 640px and 768px views.
  • The TransactionRow and TransactionRowMobile components have been refactored to support the hideSender prop, which activates/deactivates the advanced mode of the addressing column.
  • TransactionRowAddressing has been refactored to support variant and isAdvanced props. When the user has selected more than 1 wallet, the advanced mode of the addressing column activates and two of these components will render, the first always for the sender and the second one always for the recipient.
  • TransactionRowAddressing has been refactored and subdivided into child components for better readability and reduce the complexity when working with this component.
  • Unit tests have been updated to support these changes.
  • The transaction table's Value header has been renamed Amount to match the designs.

Screenshots

  • 320px
image
  • 640px
image
  • 768px
image

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@patricio0312rev patricio0312rev added this to the mainsail-evm milestone Jan 29, 2025
Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Feb 3, 2025 1:36pm

@goga-m
Copy link
Contributor

goga-m commented Jan 30, 2025

Hey @patricio0312rev one conflict appeared after merging the accent color removal.

@patricio0312rev
Copy link
Contributor Author

@samharperpittam should be ready now 🌟

Copy link

@samharperpittam samharperpittam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patricio0312rev

image

These all read Value (ARK) now instead of Amount (ARK). Can you check if it's the same for you please?

@samharperpittam samharperpittam marked this pull request as draft February 3, 2025 11:11
@patricio0312rev
Copy link
Contributor Author

@samharperpittam sorry, got confused by the mockup, should be fixed now 🌟

Copy link

@samharperpittam samharperpittam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patricio0312rev - last change request from me. In Multiwallet view, the "Amount" value shouldn't have the green/yellow/grey background and the text should be black.

Design
image

Implementation
image

@samharperpittam samharperpittam marked this pull request as draft February 3, 2025 12:54
@patricio0312rev
Copy link
Contributor Author

@samharperpittam yup, no worries my man, that's part of #930

@patricio0312rev patricio0312rev marked this pull request as ready for review February 3, 2025 13:35
@goga-m goga-m merged commit 0989d2f into feat/evm Feb 3, 2025
17 checks passed
@goga-m goga-m deleted the refactor/handle-from-to-addresses-in-multi-view-mobile branch February 3, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants