Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_Scripting: add SITL RealFlight gimbal driver #27752

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

robertlong13
Copy link
Collaborator

@robertlong13 robertlong13 commented Aug 5, 2024

Useful for testing this PR: ArduPilot/MissionPlanner#3386

Goes along with this SITL Models PR: ArduPilot/SITL_Models#140

@Georacer
Copy link
Contributor

Georacer commented Aug 5, 2024

Perhaps it's a silly question, but: What makes this driver targeted to RealFlight? Isn't it applicable to any PWM gimbal?

@robertlong13
Copy link
Collaborator Author

robertlong13 commented Aug 5, 2024

Perhaps it's a silly question, but: What makes this driver targeted to RealFlight? Isn't it applicable to any PWM gimbal?

No, you're right, it would be applicable to any PWM gimbal that stabilizes roll pitch and yaw internally, takes PWM commands for earth-frame pitch angle command and body-frame yaw angle command, and has a servo channel for zooming the camera (though that last part is optional). If there are any of that kind of gimbal still on the market (I feel like they all dried up in 2017) then this would be a nice backend for that.

The only reason this has RealFlight written all over it is that I made it for RealFlight and it works well with it.

@Georacer
Copy link
Contributor

Georacer commented Aug 6, 2024

Then if it's not too much trouble, I'd prefer seeing this be turned into such a generic PWM driver. Especially since it's placed in the drivers folder.
I realize it might need a bit more scrutiny in that case.

Of course, staying a RealFlight script (and perhaps moving it to examples) is also fine by me.

@robertlong13
Copy link
Collaborator Author

robertlong13 commented Aug 11, 2024

Then if it's not too much trouble, I'd prefer seeing this be turned into such a generic PWM driver. Especially since it's placed in the drivers folder. I realize it might need a bit more scrutiny in that case.

If someone has one they want to flight test for me, then I'd happily make it generic.

I can't even find one to buy that isn't STorM32 based, which wouldn't need this driver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants