-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition for Target Brahma F4 #27936
base: master
Are you sure you want to change the base?
Addition for Target Brahma F4 #27936
Conversation
Adding Target Brahma F4 FC Hardware has been tested with these configuration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs readme.md in this form https://github.com/ArduPilot/ardupilot/tree/master/libraries/AP_HAL_ChibiOS/hwdef/ZeroOneX6
also bootloader binary...see other hwdefs
Ok will do and update shortly |
add bootloader for brahmaf4
Hi @Hwurzburg files have been updated as requested compiled bootloader as well |
| :------- | :------- | :------ | :------------------ | | ||
| SERIAL 0 | DM/DP | USB | Mavlink | | ||
| SERIAL 1 | RX1/TX1 | USART 1 | (DMA) (Reciever) | | ||
| SERIAL 2 | RX3/TX3 | USART 3 | (NODMA) (ESC) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is Telem unless you change hwdef and make default ESC Telem....which I suggest you do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since this is pinned out as ESC telem on the ESC connector, I think not making the protocol ESC telem is a mistake
readme upate uart Co-authored-by: Henry Wurzburg <[email protected]>
msp manual change readme Co-authored-by: Henry Wurzburg <[email protected]>
Co-authored-by: Henry Wurzburg <[email protected]>
remove extra config
ap_notify led update remove commented lines
Better Grouping Documentation Co-authored-by: Henry Wurzburg <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DONE
I still have an issue about esc telem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did not understand my request re ESC telem
also need to squash and library split, but I can do that for you if you wish once the last changes are made
@ShadowWalker8642 are you still interested in pursuing this? still needs comment addressed and conflicts resolved... |
Esc telemetry default Co-authored-by: Henry Wurzburg <[email protected]>
Hi really sorry been caught up, I have done the esc telemetry change as requested |
Co-authored-by: Henry Wurzburg <[email protected]>
Co-authored-by: Henry Wurzburg <[email protected]>
Hi @Hwurzburg please tell me if anything else is needed... |
@ShadowWalker8642 unfortunately the board id has been taken already, you will need to select another and rebuild the bootloader binaries, also the commits need squashing and library split....if you like I can do that for you...bd id # 1182 is open, I can reserve that for you, and do the other stuff, if you wish |
Yes please it would very helpful Thankyou! |
#29209 PR posted...once merged, you can redo the _bl.bin file (all that is needed for bootloader binary), then if you want to try to do this (https://www.youtube.com/watch?v=iMUWQUD_Rsg) yourself ....if you have issues I can do it once the new bootloader is created and the bd ids in the .dat files is changed |
board id reserved...you can rebuild the bootloader now |
Ok thanks I will update the bl binary |
31b3e76
to
baa5d96
Compare
i have updates the bootloader can you please help me out with the rest... thankyou @Hwurzburg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you seem to have lost many of the previous changes
@@ -447,6 +447,11 @@ AP_HW_MFE_AirSpeed_CAN 6103 | |||
# IDs 7000-7099 reserved for CUAV | |||
AP_HW_CUAV-7-NANO 7000 | |||
|
|||
AP_HW_BrahmaF4 7010 | |||
|
|||
# IDs 7100-7109 reserved for VIEWPRO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will definitely cause a failure by double defining
@@ -447,6 +447,11 @@ AP_HW_MFE_AirSpeed_CAN 6103 | |||
# IDs 7000-7099 reserved for CUAV | |||
AP_HW_CUAV-7-NANO 7000 | |||
|
|||
AP_HW_BrahmaF4 7010 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not the correct bd id
Adding Target Brahma F4 F405
6 uarts,spiflash,osd,
imu bmi270
This Target has passed internal hardware testing.