AP_DDS: Added direct actuator control #29179
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snktshrma
force-pushed
the
dds/ind_motor
branch
from
3c18749 to
ee585ce
Compare
Ryanf55
reviewed
Jan 29, 2025
| } | ||
|
|
||
| guided_motor_state.update_time_ms = millis(); | ||
| memcpy(guided_motor_state.actuator, actuator, AP_MOTORS_MAX_NUM_MOTORS * sizeof(float)); |
There was a problem hiding this comment.
Suggested change
| memcpy(guided_motor_state.actuator, actuator, AP_MOTORS_MAX_NUM_MOTORS * sizeof(float)); | |
| memcpy(guided_motor_state.actuator, actuator, ARRAY_SIZE(guided_motor_state.actuator)); |
If you changed to double in the actuators, then this would not require a change.
There was a problem hiding this comment.
Hi @Ryanf55 ! So ARRAY_SIZE gives number of elements and because of that it will not copy anything after 8th element(32bytes). Either way you suggest using double(float64) instead of float32?
There was a problem hiding this comment.
I think double precision would be coverkill.
There was a problem hiding this comment.
Alright Ryan! Then I'll keep it float32 then
snktshrma
force-pushed
the
dds/ind_motor
branch
2 times, most recently
from
a3cacf1 to
08a5c3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new topic /ap/cmd_mot to allow external controllers control actuators directly. This adds support for external controller and planners (MPC, etc) to handle actuator control directly.
To run:
param set DISARM_DELAY 0ros2 topic pub /ap/experimental/cmd_mot ardupilot_msgs/msg/MotorControl "{timestamp: {sec: 0, nanosec: 0}, actuator: [0.7, 0.7, 0.7, 0.7, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0]}"This addition currently doesn't support case where publisher stops and switches the vehicle to a stable mode. In that case, the actuator output just resets to 0 (Min PWM) if no updates are received.