AP_Camera_servo: allow focus and zoom control #29247
Open
+41
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmackay9
reviewed
Feb 8, 2025
| @@ -43,6 +49,28 @@ bool AP_Camera_Servo::trigger_pic() | |||
| return true; | |||
| } | |||
|
|
|||
|
|
|||
| bool AP_Camera_Servo::set_zoom(ZoomType zoom_type, float zoom_value) { | |||
There was a problem hiding this comment.
Hi there, thanks for this. Small nitpick is in the cpp files we put the bracket on the next line
rmackay9
reviewed
Feb 8, 2025
| @@ -29,12 +29,20 @@ class AP_Camera_Servo : public AP_Camera_Backend | |||
| // Constructor | |||
| using AP_Camera_Backend::AP_Camera_Backend; | |||
|
|
|||
| void init() override; | |||
There was a problem hiding this comment.
let's put the init lower like it is in other drivers. Also if possible can we put a comment above it? I know it's pretty obvious what "init" is for but all our other methods have comments so I'd like to keep it consistent
rmackay9
reviewed
Feb 8, 2025
| @@ -6,6 +6,12 @@ | |||
|
|
|||
| extern const AP_HAL::HAL& hal; | |||
|
|
|||
|
|
|||
| void AP_Camera_Servo::init() { | |||
There was a problem hiding this comment.
here too let's put a comment and put the bracket on the next line
|
Except for the minor formatting items this looks pretty good to me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to control our camera's focus and pwm through ardupilot.