feature: splits Client into Client.Core #2399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lodicolo
requested changes
Nov 26, 2024
lodicolo
requested changes
Nov 26, 2024
| @@ -801,7 +801,7 @@ public void DrawItemNames() | |||
| var rarity = itemBase.Rarity; | |||
| if (tileItems[index].Quantity > 1) | |||
| { | |||
| name = Localization.Strings.General.MapItemStackable.ToString(name, Strings.FormatQuantityAbbreviated(quantity)); | |||
| name = Intersect.Client.Localization.Strings.General.MapItemStackable.ToString(name, Strings.FormatQuantityAbbreviated(quantity)); | |||
There was a problem hiding this comment.
Is this necessary? It should be in the same namespace right?
There was a problem hiding this comment.
Still this question outstanding
…ch still applies fix: delete unnecessary csproj fix: change assembly attribute parameter from "Intersect.Client" (period) to "Intersect Client" (space)
Arufonsu
changed the title
Arufonsu
added
feature request
WeylonSantana
force-pushed
the
client-core
branch
from
28f6d84 to
f4a598c
Compare
lodicolo
requested changes
Nov 27, 2024
Intersect.Client.Core/Program.cs
Outdated
| /// The main entry point for the application. | ||
| /// </summary> | ||
| [STAThread] | ||
| public static void Main(string[] args) |
There was a problem hiding this comment.
This shouldn't be public after our other changes?
| @@ -801,7 +801,7 @@ public void DrawItemNames() | |||
| var rarity = itemBase.Rarity; | |||
| if (tileItems[index].Quantity > 1) | |||
| { | |||
| name = Localization.Strings.General.MapItemStackable.ToString(name, Strings.FormatQuantityAbbreviated(quantity)); | |||
| name = Intersect.Client.Localization.Strings.General.MapItemStackable.ToString(name, Strings.FormatQuantityAbbreviated(quantity)); | |||
There was a problem hiding this comment.
Still this question outstanding
lodicolo
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This opens up the possibility of merging the editor with the client (and who knows what else)