Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin bar: align colors with Calypso's #39314

Merged
merged 6 commits into from
Sep 13, 2024
Merged

Admin bar: align colors with Calypso's #39314

merged 6 commits into from
Sep 13, 2024

Conversation

fushar
Copy link
Contributor

@fushar fushar commented Sep 10, 2024

Related to:

Proposed changes:

This PR updates the admin bar colors so that they match with Calypso's.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  1. IMPORTANT: Test this on a BRAND NEW Atomic site so that it fetches the updated color scheme CSS!!
  2. Patch this to Jetpack Beta Tester (Jetpack, not WP.com Features)
  3. Test along with the corresponding Calypso PR Masterbar: align colors with wp-admin's wp-calypso#94354.
  4. Test ALL color schemes and verify that the background, text, hover, icon colors etc match.

@github-actions github-actions bot added [Feature] Masterbar WordPress.com Toolbar and Dashboard customizations [Package] Masterbar [Status] In Progress labels Sep 10, 2024
Copy link
Contributor

github-actions bot commented Sep 10, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for October 1, 2024 (scheduled code freeze on September 30, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link
Contributor

github-actions bot commented Sep 10, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the admin-bar-colors branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack admin-bar-colors
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin admin-bar-colors
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@fushar fushar force-pushed the admin-bar-colors branch 3 times, most recently from 2ce355e to 81813f9 Compare September 10, 2024 09:39
@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Sep 10, 2024
@fushar fushar marked this pull request as ready for review September 11, 2024 14:00
@fushar fushar self-assigned this Sep 11, 2024
@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Sep 11, 2024
@fushar fushar force-pushed the admin-bar-colors branch 6 times, most recently from 1d54642 to a6b1f13 Compare September 11, 2024 14:30
@fushar fushar requested review from a team September 11, 2024 14:33
@allilevine
Copy link
Member

First five colors look good:

Scheme Calypso Jetpack
Default Screen Shot 2024-09-11 at 3 57 14 PM Screen Shot 2024-09-11 at 3 56 55 PM
Light Screen Shot 2024-09-11 at 3 56 34 PM Screen Shot 2024-09-11 at 3 46 35 PM
Modern Screen Shot 2024-09-11 at 3 55 38 PM Screen Shot 2024-09-11 at 3 47 27 PM
Aquatic Screen Shot 2024-09-11 at 3 55 06 PM Screen Shot 2024-09-11 at 3 51 08 PM
Blue Screen Shot 2024-09-11 at 3 54 43 PM Screen Shot 2024-09-11 at 3 53 24 PM

@allilevine
Copy link
Member

Batch 2:

Scheme Calypso Jetpack
Classic Blue Screen Shot 2024-09-11 at 4 20 20 PM Screen Shot 2024-09-11 at 4 20 35 PM
Classic Bright Screen Shot 2024-09-11 at 4 23 56 PM Screen Shot 2024-09-11 at 4 24 08 PM
Classic Dark Screen Shot 2024-09-11 at 4 25 20 PM Screen Shot 2024-09-11 at 4 25 35 PM
Coffee Screen Shot 2024-09-11 at 4 26 36 PM Screen Shot 2024-09-11 at 4 27 33 PM
Contrast Screen Shot 2024-09-11 at 4 29 16 PM Screen Shot 2024-09-11 at 4 28 55 PM

@allilevine
Copy link
Member

allilevine commented Sep 11, 2024

Last 8! Found:

  • Powder snow icon hover color is different.
  • Sakura icon hover color is different.
  • Sunset icon hover color is different.
Scheme Calypso Jetpack
Ectoplasm Screen Shot 2024-09-11 at 4 33 10 PM Screen Shot 2024-09-11 at 4 33 01 PM
Midnight Screen Shot 2024-09-11 at 4 34 51 PM Screen Shot 2024-09-11 at 4 34 42 PM
Nightfall Screen Shot 2024-09-11 at 4 36 10 PM Screen Shot 2024-09-11 at 4 35 44 PM
Ocean Screen Shot 2024-09-11 at 4 38 53 PM Screen Shot 2024-09-11 at 4 38 43 PM
Powder Snow Screen Shot 2024-09-11 at 4 42 47 PM Screen Shot 2024-09-11 at 4 42 33 PM
Sakura Screen Shot 2024-09-11 at 4 46 14 PM Screen Shot 2024-09-11 at 4 46 04 PM
Sunrise Screen Shot 2024-09-11 at 4 48 16 PM Screen Shot 2024-09-11 at 4 48 04 PM
Sunset Screen Shot 2024-09-11 at 4 50 24 PM Screen Shot 2024-09-11 at 4 50 16 PM

@fushar
Copy link
Contributor Author

fushar commented Sep 11, 2024

@allilevine thanks for testing; I've fixed all issues you found 🙏

Copy link
Member

@allilevine allilevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the colors now match for me, thanks for tackling this! ✅

WP-Admin icons go gray when I load from mobile, but that happens without this PR:

Calypso WP-Admin
Screen Shot 2024-09-12 at 1 32 37 PM Screen Shot 2024-09-12 at 1 32 23 PM

@fushar
Copy link
Contributor Author

fushar commented Sep 13, 2024

WP-Admin icons go gray when I load from mobile

I found it yesterday and already fixed it with the last commit 53f26ce 🙈 (note that it's jetpack-mu-wpcom, so it needs to be applied to WordPress.com Features)

image

@fushar fushar merged commit 57aef23 into trunk Sep 13, 2024
57 checks passed
@fushar fushar deleted the admin-bar-colors branch September 13, 2024 01:12
@github-actions github-actions bot added this to the jetpack/13.9 milestone Sep 13, 2024
@github-actions github-actions bot removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Sep 13, 2024
gogdzl pushed a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Masterbar WordPress.com Toolbar and Dashboard customizations [mu wpcom Feature] Wpcom Admin Bar [Package] Jetpack mu wpcom WordPress.com Features [Package] Masterbar [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants