Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add review plugins task #39643

Closed
wants to merge 4 commits into from
Closed

Conversation

renatho
Copy link
Contributor

@renatho renatho commented Oct 4, 2024

Fixes Automattic/wp-calypso#95075

Proposed changes:

  • Add a review plugins task on post migration.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

pfuQfP-IF-p2

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Test it on atomic. (paYKcK-5uh-p2)
  • Navigate to the home menu and make sure it has the "Review the plugins" task.
  • Navigate directly to the plugins page yoursite/wp-admin/plugins.php.
  • Return the the home menu and make sure the task is complete.

Screenshots

Screenshot 2024-10-04 at 12 06 20

Copy link
Contributor

github-actions bot commented Oct 4, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/post-migration-task-review-plugins branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/post-migration-task-review-plugins
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Oct 4, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

* @return bool True if successful, false if not.
*/
public function mark_task_complete_if_active( $task_id ) {
public function mark_task_complete_if_active( $task_id, $task_list_id = null ) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed to enhance it in order to check the tasks of the specific list.

'is_visible_callback' => '__return_true',
'is_complete_callback' => 'wpcom_launchpad_is_task_option_completed',
'add_listener_callback' => function () {
add_action( 'current_screen', 'wpcom_launchpad_track_review_plugins_task' );
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This marks the task as complete when the user navigates to the plugins page. This also happens if they navigate directly (not clicking on the task).

@renatho renatho self-assigned this Oct 4, 2024
@renatho renatho requested a review from a team October 4, 2024 15:07
@renatho renatho marked this pull request as ready for review October 4, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post-migration Experience: Add the Plugin Review task
2 participants