-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: Prevent filename conflict on @actions/upload-artifact #40042
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Boost plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I've been meaning to look into this but have never gotten around to it.
For comparison, the similar .github/files/generate-ci-matrix.php
script for our Tests workflow has a separate "artifact" property that it by default generates from the name and includes some tests to catch if anyone accidentally adds something with an invalid character.
This changes the project name in the E2E matrix from
Jetpack Boost - Concatenate JS/CSS
toJetpack Boost - Concatenate JS and CSS
.Why? If a E2E project has a name deemed invalid by
@actions/upload-artifact
, it'll fail to upload that artifact (and subsequent ones), e.g.:https://github.com/Automattic/jetpack/actions/runs/11645549949
Solving this took me down a rabbit hole (e.g. looking in the actual test name rather than the matrix, checking for upload-artifact rename abilities, GH Actions string manipulation in expression syntax). This seems to be the best and simplest solution.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Confirm artifacts are properly uploaded:
https://github.com/Automattic/jetpack/actions/runs/11672407033?pr=40042