-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Priority indicators: update logic to match new priority matrix #40672
base: trunk
Are you sure you want to change the base?
Conversation
We now ask different questions in our issue templates: #40501 This commit updates the logic to match the new questions and answers. It also captures the optional extra information ("other impact(s)") an issue can have, since that info can bump the severity, and in turn the priority, of an issue. See pfVjQF-su-p2
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Looks good to me 🙂 |
if ( | ||
( extra === 'Individual site owner revenue' || extra === 'Agency or developer revenue' ) && | ||
severity !== 'Critical' | ||
) { | ||
severity = 'Major'; | ||
} else if ( extra === 'Platform revenue' ) { | ||
severity = 'Critical'; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're allowing multiple selections for the additional-impact
in #40501. This logic assumes they can select only one.
return 'TBD'; | ||
debug( | ||
`find-priority: ${ | ||
priority === 'TBD' ? 'No ' : ' ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If priority
got changed, this will produce
find-priority: priority indicators found. Priority set to Whatever.
Should there be something other than just a space in the else case?
Note
Follow-up to #40501
I'll merge #40501 and its equivalents in our different repos that use the action once I have a review on this PR.
Proposed changes:
We now ask different questions in our issue templates:
#40501
This commit updates the logic to match the new questions and answers. It also captures the optional extra information ("other impact(s)") an issue can have, since that info can bump the severity, and in turn the priority, of an issue.
Other information:
Jetpack product discussion
See pfVjQF-su-p2
Does this pull request change what data or activity we track or use?
Testing instructions:
This can be tested in a fork.
Here is an example:
jeherve#197