Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Priority indicators: update logic to match new priority matrix #40672

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: major
Type: changed

Issue triage: update priority matrix.
Original file line number Diff line number Diff line change
Expand Up @@ -2,37 +2,78 @@ const debug = require( '../debug' );

/**
* Figure out the priority of the issue, based off issue contents.
* Logic follows this priority matrix: pciE2j-oG-p2
* Logic follows this priority matrix: pfVjQF-su-p2
*
* @param {string} body - The issue content.
* @return {string} Priority of issue.
*/
function findPriority( body ) {
let priority = 'TBD';

debug( `find-priority: Looking for priority indicators in issue body: ${ body }` );

// Look for priority indicators in body.
const priorityRegex =
/###\sImpact\n\n(?<impact>.*)\n\n###\sAvailable\sworkarounds\?\n\n(?<blocking>.*)\n/gm;
/###\sSite\sowner\simpact\n\n(?<impact>.*)\n\n###\sSeverity\n\n(?<severity>.*)\n\n###\sWhat\sother\simpact\(s\)\sdoes\sthis\sissue\shave\?\n\n(?<extra>.*)\n/gm;
let match;
while ( ( match = priorityRegex.exec( body ) ) ) {
const [ , impact = '', blocking = '' ] = match;
const { impact = '', extra = '' } = match.groups || {};
let { severity = '' } = match.groups || {};

debug(
`find-priority: Reported priority indicators for issue: "${ impact }" / "${ blocking }"`
`find-priority: Reported priority indicators for issue: "${ impact }" / "${ severity }" / "${ extra }"`
);

if ( blocking === 'No and the platform is unusable' ) {
return impact === 'One' ? 'High' : 'BLOCKER';
} else if ( blocking === 'No but the platform is still usable' ) {
return 'High';
} else if ( blocking === 'Yes, difficult to implement' ) {
return impact === 'All' ? 'High' : 'Normal';
} else if ( blocking !== '' && blocking !== '_No response_' ) {
return impact === 'All' || impact === 'Most (> 50%)' ? 'Normal' : 'Low';
// Folks can provide additional information that can bump severity.
// We also do not want that extra information to downgrade the severity.
if ( extra !== '' && extra !== '_No response_' && extra !== 'No revenue impact' ) {
if (
( extra === 'Individual site owner revenue' || extra === 'Agency or developer revenue' ) &&
severity !== 'Critical'
) {
severity = 'Major';
} else if ( extra === 'Platform revenue' ) {
severity = 'Critical';
}
Comment on lines +30 to +37
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're allowing multiple selections for the additional-impact in #40501. This logic assumes they can select only one.

}

const impactIndicators = {
isolated: 'Less than 20% of all',
scattered: 'Between 20% and 60% of all',
widespread: 'More than 60% of all',
};

if ( severity === 'Critical' ) {
priority = impact === impactIndicators.isolated ? 'High' : 'BLOCKER';
} else if ( severity === 'Major' ) {
if ( impact === impactIndicators.widespread ) {
priority = 'BLOCKER';
} else if ( impact === impactIndicators.scattered ) {
priority = 'High';
} else {
priority = 'Normal';
}
} else if ( severity === 'Moderate' ) {
if ( impact === impactIndicators.widespread ) {
priority = 'High';
} else if ( impact === impactIndicators.scattered ) {
priority = 'Normal';
} else {
priority = 'Low';
}
} else if ( severity !== '' && severity !== '_No response_' ) {
priority = impact === impactIndicators.widespread ? 'Normal' : 'Low';
} else {
priority = 'TBD';
}
return 'TBD';
}

debug( `find-priority: No priority indicators found.` );
return 'TBD';
debug(
`find-priority: ${
priority === 'TBD' ? 'No ' : ' '
Copy link
Contributor

@anomiex anomiex Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If priority got changed, this will produce

find-priority:  priority indicators found. Priority set to Whatever.

Should there be something other than just a space in the else case?

}priority indicators found. Priority set to ${ priority }.`
);
return priority;
}

module.exports = findPriority;
Loading