Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change search block's default settings #44

Merged
merged 2 commits into from
May 31, 2023

Conversation

laurelfulford
Copy link
Contributor

@laurelfulford laurelfulford commented May 30, 2023

All Submissions:

Changes proposed in this Pull Request:

This PR changes the default appearance of the search block, from:

image

... to:

image

I've used PHP to do this, but I think the "correct" way would be to use JavaScript, block variations, and the isDefault setting. Unfortunately the last one either isn't working with block variations, or isn't working the way I expect it to.

How to test the changes in this Pull Request:

  1. Apply the PR.
  2. Add a search block, either through the site editor or page/post editor.
  3. Confirm that it has the following default settings:
    • Button inside
    • Button uses an icon
    • No label
    • Placeholder set to "Search...".
  4. Try changing those options and confirm that the block lets you edit them as usual.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@laurelfulford
Copy link
Contributor Author

Awesome - thanks Derrick! 🙌

@laurelfulford laurelfulford merged commit 1487a69 into master May 31, 2023
@laurelfulford laurelfulford deleted the feat/change-search-default branch May 31, 2023 18:47
matticbot pushed a commit that referenced this pull request Jun 22, 2023
# [1.3.0-alpha.1](v1.2.2...v1.3.0-alpha.1) (2023-06-22)

### Bug Fixes

* add bottom space to post title in editor ([#60](#60)) ([ca6c9a1](ca6c9a1))
* correct single post space; add tag styles ([#59](#59)) ([f3645d0](f3645d0))
* correct spacing values ([#46](#46)) ([12cf2b4](12cf2b4))
* hide author, date for pages in search ([#53](#53)) ([52b7a7f](52b7a7f))
* make archive spacing more consistent ([#56](#56)) ([041ec88](041ec88))
* make navigation block's overlayMenu default never ([#58](#58)) ([8fa02a6](8fa02a6))
* make sure wide/full blocks can flow outside of the content ([#66](#66)) ([2e282b7](2e282b7))
* remove IDs from navigation blocks ([#50](#50)) ([1f140be](1f140be))

### Features

* add a clamp to the larger spacing sizes ([#47](#47)) ([d3a01f4](d3a01f4))
* add large image single post variation ([#54](#54)) ([838128a](838128a))
* add search toggle template parts ([#51](#51)) ([ad4e0a7](ad4e0a7))
* change search block's default settings ([#44](#44)) ([1487a69](1487a69))
* update page, homepage templates to remove unneeded elements ([#49](#49)) ([2b888cd](2b888cd))
* update search block styles ([#52](#52)) ([6ed06fb](6ed06fb))
* update search styles ([#61](#61)) ([bf0d776](bf0d776))
@matticbot
Copy link

🎉 This PR is included in version 1.3.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Jul 17, 2023
# [1.3.0](v1.2.2...v1.3.0) (2023-07-17)

### Bug Fixes

* add bottom space to post title in editor ([#60](#60)) ([ca6c9a1](ca6c9a1))
* correct single post space; add tag styles ([#59](#59)) ([f3645d0](f3645d0))
* correct spacing values ([#46](#46)) ([12cf2b4](12cf2b4))
* hide author, date for pages in search ([#53](#53)) ([52b7a7f](52b7a7f))
* make archive spacing more consistent ([#56](#56)) ([041ec88](041ec88))
* make navigation block's overlayMenu default never ([#58](#58)) ([8fa02a6](8fa02a6))
* make sure wide/full blocks can flow outside of the content ([#66](#66)) ([2e282b7](2e282b7))
* remove IDs from navigation blocks ([#50](#50)) ([1f140be](1f140be))

### Features

* add a clamp to the larger spacing sizes ([#47](#47)) ([d3a01f4](d3a01f4))
* add large image single post variation ([#54](#54)) ([838128a](838128a))
* add search toggle template parts ([#51](#51)) ([ad4e0a7](ad4e0a7))
* change search block's default settings ([#44](#44)) ([1487a69](1487a69))
* update page, homepage templates to remove unneeded elements ([#49](#49)) ([2b888cd](2b888cd))
* update search block styles ([#52](#52)) ([6ed06fb](6ed06fb))
* update search styles ([#61](#61)) ([bf0d776](bf0d776))
@matticbot
Copy link

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants