CANTINA-985: Deprecate wpcom_vip_get_page_by_path(), wpcom_vip_term_exists() and wpcom_vip_get_page_by_title()
#4983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebeccahum
force-pushed
the
deprecate_prev_uncached_helper_functions
branch
3 times, most recently
from
665451d to
3968299
Compare
rebeccahum
changed the title
wpcom_vip_get_page_by_path(), wpcom_vip_term_exists() and wpcom_vip_get_page_by_title()wpcom_vip_get_page_by_path(), wpcom_vip_term_exists() and wpcom_vip_get_page_by_title()
Codecov Report
@@ Coverage Diff @@
## develop #4983 +/- ##
=============================================
+ Coverage 28.82% 28.87% +0.04%
Complexity 4748 4748
=============================================
Files 278 278
Lines 20923 20892 -31
=============================================
Hits 6032 6032
+ Misses 14891 14860 -31
|
7 tasks
rebeccahum
force-pushed
the
deprecate_prev_uncached_helper_functions
branch
3 times, most recently
from
7fb8ff8 to
1d8203d
Compare
|
7 tasks
…pcom_vip_get_page_by_title()
rebeccahum
force-pushed
the
deprecate_prev_uncached_helper_functions
branch
from
62fd78d to
fb9fdb1
Compare
|
7 tasks
|
Closing in favour of #5343 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Given that we no longer recommend the VIP-equivalent on our docs, it's time to deprecate them since Core has added caching to these functions since 6.0+.
Since VIP only supports versions 1 version back and WP 6.4 is coming up, we should reflect that in our codebase.
Changelog Description
Functions Deprecated: wpcom_vip_get_page_by_path(), wpcom_vip_term_exists() and wpcom_vip_get_page_by_title()
wpcom_vip_get_page_by_path(),wpcom_vip_term_exists()andwpcom_vip_get_page_by_title()are now deprecated since WordPress core has added caching to these functions.Pre-review checklist
Please make sure the items below have been covered before requesting a review:
Pre-deploy checklist
Steps to Test