Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send a warning in case Jetpack is pinned but the pinned version is not available anymore #5093

Merged
merged 4 commits into from
Dec 20, 2023

Conversation

rinatkhaziev
Copy link
Contributor

@rinatkhaziev rinatkhaziev commented Dec 12, 2023

Description

Implements an error message in case the pinned version of Jetpack is not available at VIP anymore.

Previously we'd silently fall back to maximum allowed version for this specific core version, now we also log the following message:

Warning: Jetpack loading error: 8.7 could not be loaded, loading 12.9 instead.

This is mostly for develop environment purposes as mu-plugins image got extremely large, so we're going to remove some less-used versions locally. (Nothing changes for production)

Plugin Updated: Jetpack Loader

When trying to load a version of Jetpack that's not available anymore an error message is going to be logged in addition to falling back to one of compatible versions of Jetpack.

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

  • This change works and has been tested locally (or has an appropriate fallback).
  • This change works and has been tested on a Go sandbox.
  • This change has relevant unit tests (if applicable).
  • This change uses a rollout method to ease with deployment (if applicable - especially for large scale actions that require writes).
  • This change has relevant documentation additions / updates (if applicable).
  • I've created a changelog description that aligns with the provided examples.

Pre-deploy checklist

  • VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).

Steps to Test

@rinatkhaziev rinatkhaziev added the [Component] Jetpack ChangelogTagID: 636069 label Dec 12, 2023
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (8a37fe7) 28.86% compared to head (b63d44e) 28.83%.

Files Patch % Lines
jetpack.php 0.00% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #5093      +/-   ##
=============================================
- Coverage      28.86%   28.83%   -0.03%     
  Complexity      4767     4767              
=============================================
  Files            279      279              
  Lines          20995    20986       -9     
=============================================
- Hits            6060     6052       -8     
+ Misses         14935    14934       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rinatkhaziev rinatkhaziev marked this pull request as ready for review December 18, 2023 23:12
@rinatkhaziev rinatkhaziev requested a review from a team as a code owner December 18, 2023 23:12
@rinatkhaziev rinatkhaziev force-pushed the add/jp-no-pinned-version-warning branch from b6cd8fa to de15346 Compare December 18, 2023 23:12
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rinatkhaziev rinatkhaziev merged commit 971da7e into develop Dec 20, 2023
37 of 38 checks passed
@rinatkhaziev rinatkhaziev deleted the add/jp-no-pinned-version-warning branch December 20, 2023 17:36
rebeccahum pushed a commit that referenced this pull request Feb 1, 2024
…t available anymore (#5093)

* Send a warning in case Jetpack is pinned but the pinned version is not available anymore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants