Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send a warning in case Jetpack is pinned but the pinned version is not available anymore #5093

Merged
merged 4 commits into from
Dec 20, 2023
Merged

Send a warning in case Jetpack is pinned but the pinned version is not available anymore #5093

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
afe4c43
Send a warning in case Jetpack is pinned but the pinned version is no…
rinatkhaziev Dec 12, 2023
de15346
swap constant usage to constant() calls
rinatkhaziev Dec 18, 2023
91c888b
Fix text format
rinatkhaziev Dec 18, 2023
b63d44e
Merge branch 'develop' into add/jp-no-pinned-version-warning
rinatkhaziev Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion jetpack.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
<?php

/**
* Plugin Name: Jetpack
* Plugin URI: https://jetpack.com
Expand Down Expand Up @@ -596,6 +595,13 @@ function vip_jetpack_load() {

// We should break even if we failed to load Jetpack, because some constants like JETPACK_VERSION were probably already set
break;

// Trigger a E_USER_WARNING in non-production environments if the pinned version could not be loaded.
} elseif ( ! file_exists( $path ) && defined( 'VIP_JETPACK_PINNED_VERSION' ) && wp_in( constant( 'VIP_JETPACK_PINNED_VERSION' ), $path ) ) {
if ( ! defined( 'VIP_GO_APP_ENVIRONMENT' ) || 'production' !== constant( 'VIP_GO_APP_ENVIRONMENT' ) ) {
// phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
trigger_error( 'Jetpack loading error: ' . constant( 'VIP_JETPACK_PINNED_VERSION' ) . ' could not be loaded, loading ' . constant( 'VIP_JETPACK_DEFAULT_VERSION' ) . ' instead.', E_USER_WARNING );
}
}
}

Expand Down
Loading