Introduce a test drive mode into the onboarding process #9109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +1.87 kB (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
…ce-payments into add/test-drive-mode
dmallory42
reviewed
Jul 26, 2024
| updateLoaderProgress( 100, 5 ); | ||
|
|
||
| // If the account status is complete, redirect to the overview page. | ||
| // Otherwise, schedule another check after 5 seconds. |
There was a problem hiding this comment.
Suggestion: if it takes longer than 5/10 seconds, maybe we should update the message on the loader? Something like "This is taking a bit longer than expected"? Maybe one to check with design/product to see if that is something they want, though.
There was a problem hiding this comment.
I discussed this with Orcun and Elizabeth, and they stated that the progress bar should clearly indicate the remaining time. @orcunomattic, do you think we should update the messages?
There was a problem hiding this comment.
I don’t think we need to update the message but animating the progress bar would be sufficient.
|
|
||
| // If the account status is complete, redirect to the overview page. | ||
| // Otherwise, schedule another check after 5 seconds. | ||
| if ( ( account as AccountData ).status === 'complete' ) { |
There was a problem hiding this comment.
We should possibly look to have some sort of fallback logic in case the status doesn't reach complete. At the moment it looks like we'll loop around until it's complete, but I guess if there's a bug on Stripe's side and this doesn't happen, how should we handle it?
There was a problem hiding this comment.
That’s a very valid point. I have never encountered a status other than complete, but it would be a good addition.
I have updated the check so that if the progress bar is above 95 percent, we will redirect to the Overview page regardless.
There was a problem hiding this comment.
That's a great idea. Thanks!
|
Smoke-testing both client and server PR locally (round 3):
|
|
Smoke-testing both client and server PR locally (round 4):
|
vladolaru
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
I have tested (and improved) both the server PR and this PR. I am confident we can merge it. 🚢
6 tasks
|
I'm getting an error when running |
|
|
6 tasks
rafaelzaleski
pushed a commit
that referenced
this pull request
Aug 27, 2024
Co-authored-by: Vlad Olaru <[email protected]> Co-authored-by: Vlad Olaru <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9140
Changes proposed in this Pull Request
This PR replaces the existing Sandbox mode functionality and introduces one-click onboarding for test-drive accounts. This new feature aims to replicate a fully onboarded production account, excluding the ability to process live payments.
This PR is paired with this server PR: https://github.com/Automattic/woocommerce-payments-server/pull/5896
Test-Drive onboarding with Jetpack connected
Connect.Payments.WooCommerce.Payments.WooCommerce.-.25.July.2024.mp4
Test-Drive onboarding with Jetpack disconnected
Connect.Payments.WooCommerce.Payments.WooCommerce.-.25.July.2024.1.mp4
Testing instructions
Note
To test the feature, use the
add/5770-test-drive-modebranch on the server.Case 1
Completed.Enabled.Automatic.Case 2
Completed.Enabled.Automatic.Important
Ensure all the unit tests are passing!
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge