Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable hosting-overview-refinements feature flag #93616

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

fredrikekelund
Copy link
Contributor

Fixes https://github.com/Automattic/dotcom-forge/issues/8756

Proposed Changes

  • Enable the hosting-overview-refinements to launch pcYYuD-1Pw-p2

Testing Instructions

Code review should suffice. See the PT pcYYuD-1Pw-p2 for details on which features this flag will enable

@fredrikekelund fredrikekelund self-assigned this Aug 16, 2024
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 16, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug f26d/enable-hosting-overview-refinements on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@nightnei nightnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fredrikekelund fredrikekelund merged commit 56d5726 into trunk Aug 16, 2024
10 checks passed
@fredrikekelund fredrikekelund deleted the f26d/enable-hosting-overview-refinements branch August 16, 2024 14:49
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 16, 2024
@yashwin
Copy link
Contributor

yashwin commented Sep 6, 2024

👋

I also see the feature flag is enabled for Automattic for Agencies (a8c-for-agencies-*). Is this expected/used anywhere?

This was originally added here: #92987 by @chad1008

@fredrikekelund
Copy link
Contributor Author

👋 @yashwin, no it's not. I'll merge #94050 shortly to clean up the feature flag (including in the A4A config)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants