Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up hosting-overview-refinements feature flag #94050

Merged

Conversation

fredrikekelund
Copy link
Contributor

Fixes https://github.com/Automattic/dotcom-forge/issues/8757

Proposed Changes

  • Clean up the hosting-overview-refinements feature flag

Why are these changes being made?

Testing Instructions

  1. Ensure that the SSL column is still rendered to the left of Expires in the domain tables
  2. Ensure that the HostingCard component looks the same as in production for an Atomic site, a simple site, a staging site and an A4A site
  3. Ensure that WP and PHP version numbers are still rendered in the header for Atomic sites and staging sites

@fredrikekelund fredrikekelund self-assigned this Aug 30, 2024
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Aug 30, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug f26d/clean-up-hosting-overview-refinements-flag on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Aug 30, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~227 bytes removed 📉 [gzipped])

name                        parsed_size           gzip_size
hosting                          -452 B  (-0.0%)     -132 B  (-0.0%)
hosting-features                 -190 B  (-0.0%)      -78 B  (-0.0%)
domains                          -173 B  (-0.0%)      -53 B  (-0.0%)
staging-site                      -95 B  (-0.0%)      -36 B  (-0.0%)
sites-dashboard                   -95 B  (-0.0%)      -36 B  (-0.0%)
site-monitoring                   -95 B  (-0.0%)      -36 B  (-0.0%)
site-logs                         -95 B  (-0.0%)      -36 B  (-0.0%)
github-deployments                -95 B  (-0.0%)      -36 B  (-0.0%)
a8c-for-agencies-sites            -95 B  (-0.0%)      -26 B  (-0.0%)
a8c-for-agencies-referrals        -95 B  (-0.0%)      -27 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@nightnei nightnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fredrikekelund fredrikekelund merged commit 43dc289 into trunk Sep 6, 2024
11 checks passed
@fredrikekelund fredrikekelund deleted the f26d/clean-up-hosting-overview-refinements-flag branch September 6, 2024 08:34
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants