Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds thepackage for the Odie-based Jetpack.com support UI. #94082

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from

Conversation

zinigor
Copy link
Member

@zinigor zinigor commented Aug 30, 2024

This is a project to enable Odie-based bot UI in a classic WordPress.com theme.

Related to pcKp4R-C6-p2

Proposed Changes

  • Creates a package with an Odie bot element to be consumed by a browser directly.

Why are these changes being made?

  • There is currently no available Odie bot UI implementation that can be consumed by browsers.

Testing Instructions

  • TBA

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave the webpack config a once-over

apps/jetpackme-support/webpack.config.js Outdated Show resolved Hide resolved
apps/jetpackme-support/webpack.config.js Outdated Show resolved Hide resolved
apps/jetpackme-support/webpack.config.js Outdated Show resolved Hide resolved
apps/jetpackme-support/webpack.config.js Outdated Show resolved Hide resolved
apps/jetpackme-support/webpack.config.js Outdated Show resolved Hide resolved
@zinigor
Copy link
Member Author

zinigor commented Sep 2, 2024

Thanks Brad! The config is much lighter now without the unnecessary overrides!

@@ -0,0 +1,29 @@
import OdieAssistantProvider, {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I'd prefer if we moved this into an src/ directory, just for consistency between this and other apps and packages in the repo. Also handy in case we eventually need to add more code here.

@tbradsha
Copy link
Contributor

@zinigor I suspect this is now a non-issue, as the implementation went a different way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants