Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: Show 'sending email' notice #97726

Merged
merged 3 commits into from
Dec 23, 2024
Merged

Conversation

edanzer
Copy link
Contributor

@edanzer edanzer commented Dec 20, 2024

Resolves: #87174
Addresses: Automattic/jetpack#40524
Related designs and P2: p1HpG7-v7v-p2

Proposed Changes

Context: If users publish a post and then go to the newsletter stats page too quickly, they will see stats showing a small number of emails sent, which has proven confusing.

Changes:

  • We now show "Still sending emails" notice in place of stats for the first 5 minutes after a post is published.

The stats now look like this for the first 5 minutes after publishing a post:
still-sending-emails

Testing Instructions

  • Check this out and go to a test site where you have some subscribers.
  • Publish a post. If necessary, be sure to set it to send emails to subscribers.
  • Go to Stats > Subscribers > Emails > the individual page for this post (or go directly to http://calypso.localhost:3000/stats/email/opens/day/[POSTID]/[YOURWEBSITEURL])
  • Confirm you see "Still sending emails." for the first five minutes,.
  • After 5 minutes, confirm you see numbers (if you publish on a site or in a way where no emails are sent, you'll just see 0 after 5 minutes).

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Dec 20, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~81 bytes added 📈 [gzipped])

name   parsed_size           gzip_size
stats       +204 B  (+0.0%)      +81 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@edanzer edanzer requested a review from simison December 20, 2024 23:26
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 20, 2024
@edanzer edanzer self-assigned this Dec 20, 2024
@edanzer edanzer requested a review from lezama December 20, 2024 23:26
@edanzer edanzer added [Plugin] Jetpack Newsletter Stats Issues related to Newsletter Stats [Feature] Stats Everything related to our analytics product at /stats/ [Feature] Newsletter [Pri] Normal Schedule for the next available opportuinity. labels Dec 20, 2024
@matticbot
Copy link
Contributor

matticbot commented Dec 23, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • help-center
  • notifications
  • odyssey-stats
  • whats-new

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/email-stats-sending-notice on your sandbox.

@simison simison added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Dec 23, 2024
@a8ci18n
Copy link

a8ci18n commented Dec 23, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17075819

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @edanzer for including a screenshot in the description! This is really helpful for our translators.

Copy link
Member

@simison simison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Thanks.

Screenshot 2024-12-23 at 12 32 24 image

@simison simison added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 23, 2024
@edanzer edanzer merged commit a4ecff1 into trunk Dec 23, 2024
11 checks passed
@edanzer edanzer deleted the update/email-stats-sending-notice branch December 23, 2024 18:37
@github-actions github-actions bot removed [Status] Ready to Merge [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging labels Dec 23, 2024
@edanzer edanzer mentioned this pull request Dec 23, 2024
8 tasks
@a8ci18n
Copy link

a8ci18n commented Dec 29, 2024

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Newsletter [Feature] Stats Everything related to our analytics product at /stats/ Newsletter Stats Issues related to Newsletter Stats [Plugin] Jetpack [Pri] Normal Schedule for the next available opportuinity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Email stats: lock the info for first X minutes
4 participants