service deployment makefile cleanup #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbukatov
requested review from
bennerv,
geoberle,
janboll,
jmelis,
jonathan34c,
niontive,
nwnt,
SudoBrendan,
UlrichSchlueter,
weinong,
whober0521,
tony-schndr,
jharrington22 and
zgalor
as code owners
User visible changes in Makefile targets deploying service components: - cs.deploy becomes cluster-service.deploy - rp.frontend.deploy becomes frontend.deploy - rp.backend.deploy becomes backend.deploy - hypershift.deploy becomes hypershiftoperator.deploy - maestro target no longer exists - deploy.svc.all becomes svc.deployall (the same goes with mgmt target) - deploy.all becomes just deployall So that: - all targets deploying single service ends with .deploy and use the service name matching the component directory name - all targets deploying all services ends with deployall
geoberle
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Lower a cognitive load when trying to understand what components we have and how are they deployed via the makefile:
csforcluster-service,hypershiftforhypershiftoperator) - I don't want to remember multiple different names for a component. To keep things straightforward, I would like to insist on a single name of a component to be used everywhere.maestrocovering agent, server and registration - we need to handle a single component as a standalone unit in all contexts from the beginning, it will make the deps more visible.Making the svc deploy script more robust and easy to debug in case of problems (there were few explicit checks, but few others were not handled, and in case of a failure, it would not be clear what went wrong).
Ideally, we have some README which explains how we define and deploy components, which could be started in this PR if needed.
Jira: related to https://issues.redhat.com/browse/ARO-12810
Special notes for your reviewer