add nodes outbound type and enable some of the provision steps by default in CS #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziccardi
changed the title
|
@microsoft-github-policy-service agree company="Red Hat" |
ziccardi
force-pushed
the
add_nodes_outbound
branch
2 times, most recently
from
e2e4cdc to
79d007f
Compare
Now the steps are enabled by default, and the properties that enable/disable some of them have been renamed
ziccardi
force-pushed
the
add_nodes_outbound
branch
from
79d007f to
f3bf9e9
Compare
ziccardi
requested review from
bennerv,
geoberle,
janboll,
weinong,
whober0521,
tony-schndr,
mbarnes,
SudoBrendan,
jmelis,
jonathan34c,
nwnt and
UlrichSchlueter
as code owners
ziccardi
force-pushed
the
add_nodes_outbound
branch
from
6696d01 to
397f6a5
Compare
|
lgtm |
|
The outbound related changes were originally submitted in the #927 MR and reviewed there too |
geoberle
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Now the steps are enabled by default, and the properties that enable/disable some of them have been renamed
Jira:
Link to demo recording:
Special notes for your reviewer