feat: remove explicit properties enabling specific cs provisioner steps #927
Conversation
miguelsorianod
requested review from
bennerv,
mbarnes,
SudoBrendan,
geoberle,
janboll,
jmelis,
jonathan34c,
niontive,
nwnt,
UlrichSchlueter,
weinong,
whober0521 and
tony-schndr
as code owners
|
This MR can only be merged after the corresponding MR in CS has been merged and rolled out |
internal/ocm/ocm.go
Outdated
| "np_provisioner_deprovision_enabled": "true", | ||
| } | ||
| additionalProperties := map[string]string{} | ||
|
|
There was a problem hiding this comment.
I suggest just deleting this whole function and declaring a map[string]string{} where getDefaultAdditionalProperities is called.
There was a problem hiding this comment.
That's fine for me if you want. The reason I kept the function is to have it there in case in the future we want to add default properties, to have it contained in that function.
Let me know if you still prefer what you suggested.
There was a problem hiding this comment.
Understood. If there's a need in the future for always-present additional properties we can reinstate that function, but I don't foresee it. So I'd still prefer it removed, please.
There was a problem hiding this comment.
👍 I will change it then
miguelsorianod
force-pushed
the
update-cs-provisionerannotations-state
branch
from
6a8755a to
afba808
Compare
Now the steps are enabled by default, and the properties that enable/disable some of them have been renamed
miguelsorianod
force-pushed
the
update-cs-provisionerannotations-state
branch
from
afba808 to
5dd6faf
Compare
| @@ -42,7 +42,7 @@ func NewMockClusterServiceClient() MockClusterServiceClient { | |||
| func (mcsc *MockClusterServiceClient) GetConn() *sdk.Connection { panic("GetConn not implemented") } | |||
|
|
|||
| func (csc *MockClusterServiceClient) AddProperties(builder *cmv1.ClusterBuilder) *cmv1.ClusterBuilder { | |||
| additionalProperties := getDefaultAdditionalProperities() | |||
| additionalProperties := map[string]string{} | |||
There was a problem hiding this comment.
@mbarnes I also changed it here
|
We are going to rollout the changes here together with CS Image update in #961. I am closing this issue and we moved the commits in here to the other MR. |
Now the steps are enabled by default, and the properties that enable/disable some of them have been renamed.
What this PR does
Jira:
Link to demo recording:
Special notes for your reviewer