Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable goimports linter #97

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

bennerv
Copy link
Contributor

@bennerv bennerv commented May 7, 2024

What this PR does

Before this PR:
no linter on grouping of imports

After this PR:
grouping of 1p imports

Special notes for your reviewer

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

  • PR: The PR description is expressive enough and will help future contributors
  • Code: Write code that humans can understand and Keep it simple
  • Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
  • Upgrade: Impact of this change on upgrade flows was considered and addressed if required
  • Deployment: The deployment process was considered and addressed if required
  • Testing: New code requires new unit tests.
  • Documentation: Is the documentation updated? Either in the doc located in focus area, in the README or in the code itself.
  • Customers: Is this change affecting customers? Is the release plan considered?

@bennerv bennerv force-pushed the enable-goimports-linter branch from 384e3be to 134be04 Compare May 7, 2024 00:34
@mjlshen mjlshen merged commit b68fe7e into Azure:main May 7, 2024
3 checks passed
@bennerv bennerv deleted the enable-goimports-linter branch October 28, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants