Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OV-62: create-avatar-page #66

Merged
merged 2 commits into from
Sep 5, 2024
Merged

OV-62: create-avatar-page #66

merged 2 commits into from
Sep 5, 2024

Conversation

JKaypa
Copy link
Collaborator

@JKaypa JKaypa commented Aug 26, 2024

Create avatar layout component
image

@JKaypa JKaypa added the FE Fronted feature label Aug 26, 2024
@JKaypa JKaypa added this to the Release 1.0 milestone Aug 26, 2024
@JKaypa JKaypa self-assigned this Aug 26, 2024
@JKaypa JKaypa linked an issue Aug 26, 2024 that may be closed by this pull request
FEAT: Add Create avatar page #62
Closed
3 tasks
nikita-remeslov
nikita-remeslov requested changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@nikita-remeslov nikita-remeslov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check out project structure and fix your structure please!

nikita-remeslov
nikita-remeslov requested changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@nikita-remeslov nikita-remeslov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also i dont think that is common components

sergiy4
sergiy4 reviewed Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@sergiy4 sergiy4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should move these files into the 'pages' folder since this is a new page, not just a component.

nikita-remeslov
nikita-remeslov requested changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@nikita-remeslov nikita-remeslov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DRY

you duplicate all your code 2 times!

Creating avatar will be a separate resource, we can create bundle for it. Also you should add route for this page

@JKaypa JKaypa linked an issue Aug 28, 2024 that may be closed by this pull request
FEAT: Sidebar component #13
Closed
7 tasks
This was unlinked from issues Aug 28, 2024
FEAT: Sidebar component #13
Closed
FEAT: Add Create avatar page #62
Closed
@JKaypa
Copy link
Collaborator Author

JKaypa commented Aug 28, 2024

image
image

@JKaypa JKaypa requested a review from nikita-remeslov August 28, 2024 21:42
This was linked to issues Aug 28, 2024
FEAT: Add Create avatar page #62
Closed
FEAT: Sidebar component #13
Closed
@stefano-lacorazza stefano-lacorazza mentioned this pull request Aug 29, 2024
Merged
This was unlinked from issues Aug 29, 2024
FEAT: Sidebar component #13
Closed
FEAT: Add Create avatar page #62
Closed
@JKaypa JKaypa linked an issue Aug 29, 2024 that may be closed by this pull request
FEAT: Add Create avatar page #62
Closed
3 tasks
@JKaypa
Copy link
Collaborator Author

JKaypa commented Aug 29, 2024

We should merge sidebar before this one.

@nikita-remeslov
Copy link
Collaborator

Please update the target brach. Your PR include changes from another

@JKaypa JKaypa changed the base branch from next to task/OV-13-add-side-bar-component September 2, 2024 12:10
Base automatically changed from task/OV-13-add-side-bar-component to next September 2, 2024 14:30
@Sanchousina
Copy link
Collaborator

Sanchousina commented Sep 2, 2024 •
edited
Loading

Why are there 0 files changed right now?...

@JKaypa
Copy link
Collaborator Author

JKaypa commented Sep 2, 2024

Why are there 0 files changed right now?...

I guess because it was merged with sidebar component, and that one was merged to next already

@o-nedashkivska
Copy link
Collaborator

Why are there 0 files changed right now?...

I guess because it was merged with sidebar component, and that one was merged to next already

You should close the pr if there are no changes

@JKaypa
Copy link
Collaborator Author

JKaypa commented Sep 3, 2024

Why are there 0 files changed right now?...

I guess because it was merged with sidebar component, and that one was merged to next already

You should close the pr if there are no changes

Yes, I guess so

@nikita-remeslov nikita-remeslov merged commit 2938d41 into next Sep 5, 2024
2 checks passed
@nikita-remeslov nikita-remeslov deleted the task/OV-62-create-avatar-page branch September 5, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-otroshchenko anton-otroshchenko anton-otroshchenko left review comments

@sofiia-trokhymchuk sofiia-trokhymchuk Awaiting requested review from sofiia-trokhymchuk

@sergiy4 sergiy4 Awaiting requested review from sergiy4

@nikita-remeslov nikita-remeslov Awaiting requested review from nikita-remeslov

Assignees

@JKaypa JKaypa

Labels
FE Fronted feature
Projects
bsa-2024-outreachvids
Status: To Be Tested
Milestone
Pre-DEMO Release
Development

Successfully merging this pull request may close these issues.

FEAT: Add Create avatar page
7 participants
@JKaypa @nikita-remeslov @Sanchousina @o-nedashkivska @sergiy4 @anton-otroshchenko @sofiia-trokhymchuk