Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OV-4: Hide Default Password input Reveal Functionality #68

Merged
merged 7 commits into from
Aug 28, 2024

Conversation

lfelix3011
Copy link
Collaborator

This Pull Request is to solve this review #4 (comment)

Test did in edge browser
image

@lfelix3011 lfelix3011 added the FE Fronted feature label Aug 26, 2024
@lfelix3011 lfelix3011 added this to the Release 1.0 milestone Aug 26, 2024
@lfelix3011 lfelix3011 self-assigned this Aug 26, 2024
@lfelix3011 lfelix3011 linked an issue Aug 26, 2024 that may be closed by this pull request
15 tasks
@lfelix3011 lfelix3011 mentioned this pull request Aug 26, 2024
15 tasks
o-nedashkivska
o-nedashkivska previously approved these changes Aug 27, 2024
@o-nedashkivska o-nedashkivska mentioned this pull request Aug 27, 2024
15 tasks
@@ -12,6 +12,9 @@ const global = {
flexGrow: 1,
flexDirection: 'column',
},
'input::-ms-clear, input::-ms-reveal': {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment what these styles do

@sofiia-trokhymchuk sofiia-trokhymchuk merged commit d3478a3 into next Aug 28, 2024
2 checks passed
@sofiia-trokhymchuk sofiia-trokhymchuk deleted the fix/OV-4-hide-default-input-pass-reveal branch August 28, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FE Fronted feature
Projects
Status: To Be Tested
Development

Successfully merging this pull request may close these issues.

FEAT: Sign Up flow
5 participants