Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue bill flow #49

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Issue bill flow #49

merged 2 commits into from
Nov 14, 2024

Conversation

cryptosalomao
Copy link
Collaborator

@cryptosalomao cryptosalomao commented Nov 13, 2024

@cryptosalomao cryptosalomao self-assigned this Nov 13, 2024
Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
e-bill-frontend ✅ Ready (Inspect) Visit Preview Nov 14, 2024 4:41am

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 1.81818% with 324 lines in your changes missing coverage. Please review.

Project coverage is 5.91%. Comparing base (4649297) to head (9db2bd0).
Report is 1 commits behind head on revamp.

Files with missing lines Patch % Lines
src/pages/CreateBill.tsx 0.00% 139 Missing ⚠️
src/pages/PreviewBill.tsx 0.00% 114 Missing ⚠️
src/pages/IssueBill.tsx 0.00% 56 Missing ⚠️
src/main.tsx 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           revamp     #49      +/-   ##
=========================================
- Coverage    6.47%   5.91%   -0.56%     
=========================================
  Files          35      38       +3     
  Lines        2441    2771     +330     
  Branches       52      55       +3     
=========================================
+ Hits          158     164       +6     
- Misses       2283    2607     +324     
Flag Coverage Δ
unittests 5.91% <1.81%> (-0.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@zupzup zupzup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

/>
</h1>
<span className="font-normal text-text-200 text-base text-center px-0.5 leading-6">
<FormattedMessage
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text here cuts off at "where you". It's in Figma as well, but I wonder why 🤔

@mtbitcr mtbitcr merged commit 29a6b35 into revamp Nov 14, 2024
2 of 4 checks passed
cryptosalomao added a commit that referenced this pull request Nov 15, 2024
* initial files

* chore: change text style

* initial version for onboard flow

* chore: add validation to file field

* chore: setup react router

* chore: initial service integration

* chore: remove pwa checker from EnvironmentAction function

* chore: update design primitives

* chore: configure font family with css

* chore: configure fonts.css

* chore: create login screen

* chore: fix aspect ratio

* chore: change illustration position

* chore: unlock with PIN

* chore: fix icons; fix alignment

* fix deployment

* chore: fix deployment

* chore: add rewrite rule for vercel deployments

* chore: create initial translations

* chore: add more translations

* chore: remove old homepage; change root route to Login page

* chore: add i18n functionalities

* chore: add test setup

* chore: add test setup

* chore: create identity recovery pages

* chore: add paste actions

* chore: add links and fix layout dimensions

* chore: add sample test cases for Unlock screen

* chore: import proper typedefs for mocked function

* chore: clanup

* chore: remove data-testid property from components

* chore: create home page component (#21)

* chore: make CI pipeline run after pushing commits to an open PR (#25)

* chore: create notifications page (#37)

* Identity creation flow (#23)

* chore: create identity start page

* chore: add more onboarding components

* chore: fix vercel deployment

* chore: update select component layout

* chore: fix component typedefs

* chore: fix upload component behavior

* wip

* chore: add navigation between screens

* Bills list overview (#38)

* chore: create notifications page

* bills list components

* Issue bill flow (#49)

* start bill creation flow

* create bill and preview bill pages

* View bill page (#48)

* chore: create bill visualization page

* chore: add header action buttons

* fix route path

* ignore generated incremental build files

---------

Co-authored-by: MT <[email protected]>
cryptosalomao added a commit that referenced this pull request Nov 16, 2024
* initial files

* chore: change text style

* initial version for onboard flow

* chore: add validation to file field

* chore: setup react router

* chore: initial service integration

* chore: remove pwa checker from EnvironmentAction function

* chore: update design primitives

* chore: configure font family with css

* chore: configure fonts.css

* chore: create login screen

* chore: fix aspect ratio

* chore: change illustration position

* chore: unlock with PIN

* chore: fix icons; fix alignment

* fix deployment

* chore: fix deployment

* chore: add rewrite rule for vercel deployments

* chore: create initial translations

* chore: add more translations

* chore: remove old homepage; change root route to Login page

* chore: add i18n functionalities

* chore: add test setup

* chore: add test setup

* chore: create identity recovery pages

* chore: add paste actions

* chore: add links and fix layout dimensions

* chore: add sample test cases for Unlock screen

* chore: import proper typedefs for mocked function

* chore: clanup

* chore: remove data-testid property from components

* chore: create home page component (#21)

* chore: make CI pipeline run after pushing commits to an open PR (#25)

* chore: create notifications page (#37)

* Identity creation flow (#23)

* chore: create identity start page

* chore: add more onboarding components

* chore: fix vercel deployment

* chore: update select component layout

* chore: fix component typedefs

* chore: fix upload component behavior

* wip

* chore: add navigation between screens

* Bills list overview (#38)

* chore: create notifications page

* bills list components

* Issue bill flow (#49)

* start bill creation flow

* create bill and preview bill pages

* View bill page (#48)

* chore: create bill visualization page

* chore: add header action buttons

* fix route path

* ignore generated incremental build files

* chore: removed unused code

* create mint and sell bill pages (#52)

---------

Co-authored-by: MT <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Start bill issuing process screen Create preview issue bill screen Create issue bill form
3 participants