-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
160 fix all warnings during the build #188
Conversation
540c3f1
to
6b716b6
Compare
6b716b6
to
ede884f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, only 3 minor comments
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #188 +/- ##
=========================================
- Coverage 4.19% 4.04% -0.15%
=========================================
Files 29 29
Lines 7175 6871 -304
=========================================
- Hits 301 278 -23
+ Misses 6874 6593 -281 ☔ View full report in Codecov by Sentry. |
This implements #160 and fixes all warnings and clippy warnings.
The changes were all done in a way so there is no logic change.