Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

160 fix all warnings during the build #188

Merged
merged 6 commits into from
Oct 28, 2024

Conversation

zupzup
Copy link
Collaborator

@zupzup zupzup commented Oct 24, 2024

This implements #160 and fixes all warnings and clippy warnings.

The changes were all done in a way so there is no logic change.

@zupzup zupzup requested review from tompro, upoi and mtbitcr October 24, 2024 17:36
@zupzup zupzup self-assigned this Oct 24, 2024
@zupzup zupzup linked an issue Oct 24, 2024 that may be closed by this pull request
@zupzup zupzup force-pushed the 160-fix-all-warnings-during-the-build branch from 540c3f1 to 6b716b6 Compare October 24, 2024 20:32
@zupzup zupzup marked this pull request as ready for review October 24, 2024 20:33
@zupzup zupzup force-pushed the 160-fix-all-warnings-during-the-build branch from 6b716b6 to ede884f Compare October 24, 2024 20:44
Copy link
Contributor

@mtbitcr mtbitcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, only 3 minor comments

src/external/bitcoin.rs Outdated Show resolved Hide resolved
src/external/bitcoin.rs Outdated Show resolved Hide resolved
src/external/bitcoin.rs Outdated Show resolved Hide resolved
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 9.48905% with 124 lines in your changes missing coverage. Please review.

Project coverage is 4.04%. Comparing base (072752c) to head (f1d31e6).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
src/dht/client.rs 0.00% 32 Missing ⚠️
src/external/bitcoin.rs 0.00% 27 Missing ⚠️
src/blockchain/block.rs 0.00% 21 Missing ⚠️
src/bill/mod.rs 0.00% 14 Missing ⚠️
src/web/handlers/bill.rs 0.00% 13 Missing ⚠️
src/blockchain/chain.rs 0.00% 12 Missing ⚠️
src/util/rsa.rs 0.00% 2 Missing ⚠️
src/dht/event_loop.rs 0.00% 1 Missing ⚠️
src/external/mint.rs 0.00% 1 Missing ⚠️
src/external/time.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master    #188      +/-   ##
=========================================
- Coverage    4.19%   4.04%   -0.15%     
=========================================
  Files          29      29              
  Lines        7175    6871     -304     
=========================================
- Hits          301     278      -23     
+ Misses       6874    6593     -281     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zupzup zupzup mentioned this pull request Oct 25, 2024
@zupzup zupzup requested a review from mtbitcr October 25, 2024 19:17
@mtbitcr mtbitcr merged commit 27463d8 into master Oct 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix all warnings during the build
2 participants