[other] [1/2] ENGMT-1983: improvements to the example page #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bredmond5
force-pushed
the
ENGMT-1983
branch
from
52b52af to
ff0449f
Compare
bredmond5
changed the title
bredmond5
commented
Dec 16, 2024
src/6_branch.js
Outdated
| @@ -1936,6 +1926,17 @@ Branch.prototype['disableTracking'] = wrap(callback_params.CALLBACK_ERR, functio | |||
| done(); | |||
| }, /* allowed before init */ true); | |||
|
|
|||
| Branch.prototype['enableTracking'] = function() { | |||
There was a problem hiding this comment.
let me know if you want me to remove this. I just find branch.disableTracking(false) to be annoying. Additionally, with this i didnt add the wrap or callback because nothing actually async happens
There was a problem hiding this comment.
I think the addition is okay. On other SDKs we are deprecating disableTracking for another set of APIs, not sure if it applies to this sdk but just fyi cc @nsingh-branch
There was a problem hiding this comment.
The new CPP level methods will deprecate disableTracking, so it may not worth it add it if we plan on deprecating it soon anyways. However, i'm not sure when CPP for Web is planned
gdeluna-branch
approved these changes
Dec 16, 2024
bredmond5
force-pushed
the
ENGMT-1983
branch
from
ff0449f to
59e5202
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Updates a lot of the styling / look of the page to make it nicer to use. I also added a convenience method enableTracking to the websdk. Finally cleaned up a lot of stuff in the example.template.html
Next, i am thinking about what to do for the request and response stuff at the top. I would love it if we could print out exactly what api request happened but i need to think more about that
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
JS Budget Check
Please mention the size in kb before abd after this PR
Checklist:
Mentions:
List the person or team responsible for reviewing proposed changes.
cc @BranchMetrics/saas-sdk-devs for visibility.