Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BI-2055] - Remove missingValueString tablesaw values #2

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

HMS17
Copy link

@HMS17 HMS17 commented Jan 30, 2025

Description

Story: BI-2055 - Remove missingValueString tablesaw values

NOTE: This is a redo of #1, with the difference of not including null in the values to be removed due to that being responsible bi-api unit test failures.

Default tablesaw behavior silently converts certain values to an empty string when processing tables, which can lead to unexpected behavior when importing files in DeltaBreed. This follows up on work implemented in BI-1993 to also remove this silent conversion for N/A, NaN, *, and null values and update associated tests.

Dependencies

n/a

Testing

Performed locally, very aggravating to set up so unclear what testing can be done by others before merging and seeing if bi-api unit tests pass?

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@HMS17 HMS17 marked this pull request as ready for review January 31, 2025 00:11
@HMS17 HMS17 requested review from davedrp and mlm483 January 31, 2025 14:29
@davedrp davedrp self-assigned this Feb 4, 2025
@HMS17 HMS17 merged commit 68a39fc into master Feb 5, 2025
6 checks passed
@HMS17 HMS17 deleted the bug/BI-2055-1 branch February 5, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants