Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BI-2055] - Remove missingValueString tablesaw values #2

Merged
merged 1 commit into from
Feb 5, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions core/src/main/java/tech/tablesaw/io/TypeUtils.java
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,12 @@
public final class TypeUtils {

/** Strings representing missing values in, for example, a CSV file that is being imported */
private static final String missingInd1 = "NaN";

private static final String missingInd2 = "*";
private static final String missingInd3 = "NA";
private static final String missingInd4 = "null";
private static final String missingInd5 = "N/A";

// No default missing indicators
// Only null should be default missing indicator for now. null will be removed in BI-2486
// TODO: Allow this to be configurable?
public static final ImmutableList<String> MISSING_INDICATORS =
ImmutableList.of(missingInd1, missingInd2, missingInd4, missingInd5);
ImmutableList.of(missingInd4);

/** Private constructor to prevent instantiation */
private TypeUtils() {}
Expand Down
2 changes: 1 addition & 1 deletion core/src/test/java/tech/tablesaw/io/csv/CsvReaderTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -528,7 +528,7 @@ void testWithMissingValue2() throws IOException {

Table t = Table.read().csv("../data/missing_values2.csv");
assertEquals(1, t.stringColumn(0).countMissing());
assertEquals(1, t.numberColumn(1).countMissing());
assertEquals(0, t.numberColumn(1).countMissing());
assertEquals(0, t.numberColumn(2).countMissing());
}

Expand Down