✨ GC-1464 Remember the last resize position #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timbryandev
requested review from
kyleharper,
webknit,
lewishankinson,
AmeeMorris and
micmcgrorty
AmeeMorris
approved these changes
Sep 29, 2023
lib/hooks/useLocalStorage.ts
Outdated
| const [localStorageValue, setLocalStorageValue] = useState(() => { | ||
| try { | ||
| // Try and retrieve any previously recorded values | ||
| const value = localStorage.getItem(key); |
There was a problem hiding this comment.
I think you could name this currentValue/previousValue and then just do away with the comments
There was a problem hiding this comment.
Ah good feedback! I've renamed and refactored out the comments, especially in the catch as its pretty clear we're using the default in the catch :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💬 Description
Builds on the new Resizable component. This PR adds a new useLocalStorage hook to record the last width a component may have been resized to and can be restored to using that locally recorded value.
Uses the new
rememberPositionboolean prop to enable the functionality, and will use the new optionalidstring prop to record instances uniquely.Added a new story too to demonstrate usage.