-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ GC-1464 Remember the last resize position #1305
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e014db9
:sparkles: create hook for local storage
timbryandev 46e6e29
:sparkles: remember last resized position
timbryandev 682db10
:sparkles: record positions uniquely
timbryandev 1c6beb3
:recycle: remove superfluous calls to toPixels for initialWidth
timbryandev 4847843
:recycle: rename and refactor out comments
timbryandev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
import { useState } from "react"; | ||
|
||
export const useLocalStorage = (key: string, defaultValue: unknown) => { | ||
const [localStorageValue, setLocalStorageValue] = useState(() => { | ||
try { | ||
// Try and retrieve any previously recorded values | ||
const value = localStorage.getItem(key); | ||
if (value) { | ||
return JSON.parse(value); | ||
} | ||
|
||
// Else, record the defaultValue and return it instead | ||
localStorage.setItem(key, JSON.stringify(defaultValue)); | ||
return defaultValue; | ||
} catch (error) { | ||
// Fallback to the defaultValue if we can't retrieve a previous value | ||
localStorage.setItem(key, JSON.stringify(defaultValue)); | ||
return defaultValue; | ||
} | ||
}); | ||
|
||
const setLocalStorageStateValue = (value: unknown) => { | ||
localStorage.setItem(key, JSON.stringify(value)); | ||
setLocalStorageValue(value); | ||
}; | ||
|
||
return [localStorageValue, setLocalStorageStateValue]; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you could name this
currentValue
/previousValue
and then just do away with the commentsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good feedback! I've renamed and refactored out the comments, especially in the catch as its pretty clear we're using the default in the catch :D