Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Pydantic mypy plugin #254

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

jdeschamps
Copy link
Member

@jdeschamps jdeschamps commented Oct 20, 2024

We have been using mypy and Pydantic together wrong. This PR will require some additional mypy fixing.

https://docs.pydantic.dev/latest/integrations/mypy/#enabling-the-plugin

Description

Please provide a brief description of the changes in this PR. Include any relevant context or background information.

  • What: Clearly and concisely describe what changes you have made.
  • Why: Explain the reasoning behind these changes. What problem are you solving? Why is this change necessary?
  • How: Describe how you implemented these changes. Provide an overview of the approach and any important implementation details.

Changes Made

  • Added: List new features or files added.
  • Modified: Describe existing features or files modified.
  • Removed: Detail features or files that were removed.

Related Issues

Link to any related issues or discussions. Use keywords like "Fixes", "Resolves", or "Closes" to link to issues automatically.

  • Fixes #
  • Resolves #
  • Closes #

Breaking changes

Describe any breaking change.

Additional Notes and Examples

Include any additional notes or context that reviewers should be aware of, including snippets of code illustrating your new feature.


Please ensure your PR meets the following requirements:

  • Code builds and passes tests locally, including doctests
  • New tests have been added (for bug fixes/features)
  • Pre-commit passes
  • PR to the documentation exists (for bug fixes / features)

Copy link

codecov bot commented Oct 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.57%. Comparing base (929b9b8) to head (243d552).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #254      +/-   ##
==========================================
+ Coverage   87.20%   87.57%   +0.36%     
==========================================
  Files         131      135       +4     
  Lines        4956     4950       -6     
==========================================
+ Hits         4322     4335      +13     
+ Misses        634      615      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant