[NOREF] Add SQLFluff linter #2904
Conversation
ClayBenson94
requested review from
samoddball and
mynar7
and removed request for
a team
| UNION | ||
| SELECT modified_by AS username | ||
| FROM trb_request_system_intakes | ||
| ) AS combined_usernames |
There was a problem hiding this comment.
Side note: good lord what is this? Unions pulling data from every table?
There was a problem hiding this comment.
@mynar7 , yeah this was for migrating to the user account table. We needed to get the usernames that might not have a user account representation.
|
For some reason this PR is now failing the I might need to make another PR to address that https://github.com/CMS-Enterprise/easi-app/actions/runs/12031770967/job/33545711634#step:8:169 |
| - id: sqlfluff-fix | ||
| exclude: ^migrations/ | ||
| - id: sqlfluff-lint | ||
| exclude: ^migrations/ |
There was a problem hiding this comment.
I think I've addressed ignoring old migrations if you want to lint any new ones
CMS-Enterprise/mint-app#1538.
Note, anytime we upgrade linter versions, we likely would want to update the regex to not change indentation etc
There was a problem hiding this comment.
I'm gonna merge this PR as-is and we can loop back on enabling this for migrations later, if that's alright!
There was a problem hiding this comment.
that's great with me!
NOREF
Description
This will lint all
.sqlfiles that don't live in the/migrationsfolder (since we can't edit old migrations, running this linter on that folder would result in that)Note
We're using the SQLFluff core rules by default, but feel free to look at all the rules to see if anything else would be useful!
How to test this change
.sqlfile (somewhere in/pkgwould be easiest) to update something like indentation, casing, or formatpre-commit run --all sqlfluff-fixImportant
There's a lot of files touched in this PR - exhaustively going over each one in detail probably isn't reasonable, but I recommend looking over each generally to make sure the types of changes are what we're comfortable with (spacing? formatting? indentation? capitalization?)
PR Author Checklist
PR Reviewer Guidelines