Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOREF] Remove TailScale references #2905

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

ClayBenson94
Copy link
Collaborator

@ClayBenson94 ClayBenson94 commented Nov 26, 2024

NOREF

Description

  • Removes references to tailscale that were causing occasional lint failures (see this job and this comment)

How to test this change

This is just removing code, so just ensuring that there's no more references to tailscale and that everything boots as expected in CI / with scripts/dev up should suffice!

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

@ClayBenson94 ClayBenson94 requested a review from a team as a code owner November 26, 2024 14:44
@ClayBenson94 ClayBenson94 requested review from aterstriep and removed request for a team November 26, 2024 14:44
@ClayBenson94 ClayBenson94 requested review from mynar7 and removed request for aterstriep November 26, 2024 14:45
@ClayBenson94 ClayBenson94 merged commit 3b5950e into main Nov 26, 2024
12 checks passed
@ClayBenson94 ClayBenson94 deleted the NOREF/remove_tailscale branch November 26, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants