Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOREF] sqlfluff targets migrations after v180 #1538

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

StevenWadeOddball
Copy link
Contributor

@StevenWadeOddball StevenWadeOddball commented Nov 26, 2024

Description

This PR introduces linting to the migration folder! IT uses regex to exclude any migration previous to migration 180.

How to test this change

  1. Run pre-commit run --all sqlfluff-fix
  2. Ensure that no migrations are changed (for example V80 has indentation that could change)
  3. Add and stage a new migration with a number greater than 180, ensure that pre-commit run --all sqlfluff-fix runs against it

Hint, you can look at the files it matches by scrolling up after running the command

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.
  • Updated the Postman Collection if necessary.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

@StevenWadeOddball StevenWadeOddball marked this pull request as ready for review November 26, 2024 14:56
@StevenWadeOddball StevenWadeOddball requested a review from a team as a code owner November 26, 2024 14:56
@StevenWadeOddball StevenWadeOddball requested review from OddTomBrooks and ClayBenson94 and removed request for a team November 26, 2024 14:56
@StevenWadeOddball
Copy link
Contributor Author

@ClayBenson94, do you think your fix in EASI removing the tailscale references is also the fix for this lint failure?

OddTomBrooks
OddTomBrooks previously approved these changes Nov 26, 2024
Copy link
Contributor

@OddTomBrooks OddTomBrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and functions as expected

Copy link
Contributor

@OddTomBrooks OddTomBrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still works as expected

@StevenWadeOddball StevenWadeOddball merged commit 39a432c into main Dec 12, 2024
12 of 13 checks passed
@StevenWadeOddball StevenWadeOddball deleted the NOREF/sqlfluff_targets_migrations_after_v180 branch December 12, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants