Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOREF] sqlfluff targets migrations after v180 #1538

Merged
merged 3 commits into from
Dec 12, 2024
Merged

[NOREF] sqlfluff targets migrations after v180 #1538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
02d4a38
feat: add regex to lint sql migrations after V180
StevenWadeOddball Nov 26, 2024
0392c84
feat: add comments about regex to exclude original migrations
StevenWadeOddball Nov 26, 2024
052291a
chore: comment out APP_DIR to accomodate the shell lint
StevenWadeOddball Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .envrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#########################

# Helpers for .envrc
APP_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
# APP_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"

# Set environment to local to avoid deployed environment specifics (like auth)
export APP_ENV=local
Expand Down
8 changes: 6 additions & 2 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,13 @@ repos:
rev: 3.2.5
hooks:
- id: sqlfluff-fix
exclude: ^migrations/
# Exclude SQL files in the migrations folder with version numbers V0 to V180.
# Matches single-digit (e.g., V0), two-digit (e.g., V99), and three-digit (e.g., V180) versions.
exclude: 'migrations/V([0-9]{1,2}|1[0-7][0-9]|180)__'
- id: sqlfluff-lint
exclude: ^migrations/
# Exclude SQL files in the migrations folder with version numbers V0 to V180.
# Matches single-digit (e.g., V0), two-digit (e.g., V99), and three-digit (e.g., V180) versions.
exclude: 'migrations/V([0-9]{1,2}|1[0-7][0-9]|180)__'

- repo: local
hooks:
Expand Down
Loading