[ENG-4077] Fix accessing component's registration

[chth0n1x]

• Ticket: https://openscience.atlassian.net/browse/ENG-4077
• Branch name: fix-accessing-components-registration

Purpose

The purpose of these changes is to fix accessing a component's registration from the component's project registrations page.

Summary of Changes

• Updated the return value of the overview index route's root function
• Updated the overview page's OsfLink models array value if it is the root
• Updated the link text for the registry overview page to display on the registration

Screenshot(s)

Figure 1: OsfLink now displays on the registries overview page of linked projects

Side Effects

There should be no side effects.

QA Notes

-Does the link text now properly display?
-Does the link route you to the appropriate component?
-Does the rest of the registration summary now display when opened from the project registration page?

[coveralls]

Pull Request Test Coverage Report for Build 6510376027

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-0.02%) to 71.215%

---

Files with Coverage Reduction	New Missed Lines	%
lib/registries/addon/overview/-components/diff-manager/component.ts	2	67.8%

Totals
Change from base Build 6483532224:	-0.02%
Covered Lines:	5941
Relevant Lines:	8129

---

💛 - Coveralls

[adlius]

This does fix the problem, but adds an unnecessary AJAX call to fetch the asynchronous root relationship.
There is a reason why the bug only happens when you transition from the project's registration list view to the registration overview page by clicking the link, but not when you go to the registration overview page directly. There is some race condition going on here and the proper fix would be to address the race condition.

[adlius]

Tested locally and it seems it's not quite doing what it's supposed to do.

The correct behavior of the page:

1. When the registration is a root registration, it should not show any link.
2. When the registration is a non-root registration, it should show a link pointing to the root registration

However the behavior of the page after these changes would be:

1. When the registration is a root registration, it shows a link pointing to itself.
2. When the registration is a non-root registration, it doesn't show any link.

[adlius]

Checked locally again. The link is missing after transitioning from the registration list to the registration overview page.

I'd like to expand more on the cause of the bug. Ember has asynchronous routing feature. That means, if the route model hook of a particular route returns a promise (as is the case with guid-route route), the route transition would happen after the promise returned by the model hook is resolved. In this case, the bug happens because the promise returned by the model hook does resolve, but the root relationship of the registration has still yet to be loaded. Note that this happens only when your transition from the registration list view to the registration overview route. The fix to the bug requires understanding why the promise returned by the model hook resolves but the root relationship is still not loaded.