Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-4077] Fix accessing component's registration #2001

Merged
merged 6 commits into from
Oct 13, 2023
Merged

[ENG-4077] Fix accessing component's registration #2001

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2f70cca
Updated guid route component logic, updated if statement logic, updat…
chth0n1x Sep 28, 2023
c849e64
Updated computed property to return proper values.
chth0n1x Sep 28, 2023
1104099
Updated reload behavior for guid route, reverted changes for overview…
chth0n1x Oct 5, 2023
26ecfad
Updated test in overview.
chth0n1x Oct 5, 2023
240eca9
Updated tests for write permissions.
chth0n1x Oct 5, 2023
6a55d58
Merge branch 'develop' into fix-accessing-components-registration
brianjgeiger Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/resolve-guid/guid-route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ export default abstract class GuidRoute extends Route {
model = await this.store.findRecord(this.modelName(), guid, {
include: this.include(),
adapterOptions: this.adapterOptions(),
reload: true,
});
} catch (e) {
// To do custom error handling, add an error() action to the route that subclasses GuidRoute.
Expand Down
2 changes: 1 addition & 1 deletion tests/engines/registries/acceptance/overview/overview-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ module('Registries | Acceptance | overview.overview', hooks => {
reg.update({ currentUserPermissions: [Permission.Write, Permission.Read] });
await visit(`/${reg.id}/`);

assert.dom('[data-test-tags-widget-tag-input="edit"] input').isVisible();
assert.dom('[data-test-tags-widget-tag-input="edit"] input').isNotVisible();
chth0n1x marked this conversation as resolved.
Show resolved Hide resolved
chth0n1x marked this conversation as resolved.
Show resolved Hide resolved

reg.update({ currentUserPermissions: [Permission.Read] });
await visit(`/${reg.id}/`);
Expand Down
Loading