-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next step 1: Add a TLA plus model #64
Open
prozacchiwawa
wants to merge
41
commits into
main
Choose a base branch
from
20250127-tla-plus-model
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…which doesn't find itself deadlocked (for example, nobody has the potato). It can be improved. It doesn't model all error types yet, so some rearranging may be needed to ensure error propogation keeps invariants
This reverts commit c86ba2e.
…_needed as in the model
…quest potato just to send it
…game factory call.
Draft
aqk
previously approved these changes
Mar 8, 2025
Next step 2, remove some unused my turn/their turn parameters in potato handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the model describes a way of building potato handler which doesn't find itself deadlocked (for example, nobody has the potato). It can be improved. It doesn't model all error types yet, so some rearranging may be needed to ensure error propogation keeps invariants.
this branch also hosts changes that make src/potato_handler/mod.rs work like the model (some changes are needed) and the model actually makes the potato request handling more regular with other event handling.
Fairly certain behaviorally, the tla+ model and potato_handler/mod.rs are in sync now.