Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add zero address check in all initializers #145

Merged
merged 2 commits into from
May 23, 2022
Merged

add zero address check in all initializers #145

merged 2 commits into from
May 23, 2022

Conversation

brianendo
Copy link
Contributor

addresses the issue #138. added the check on all addresses to ensure safety

@dapp-whisperer @shuklaayush please take a look

@brianendo brianendo mentioned this pull request May 6, 2022
Open
@shuklaayush shuklaayush force-pushed the feat/zero-address-check branch from 7fd6781 to 76e25dd Compare May 23, 2022 11:51
@shuklaayush
Copy link
Contributor

Tests passing locally

sajanrajdev
sajanrajdev approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@sajanrajdev sajanrajdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds address zero checks to initializer params.

LGTM

@shuklaayush shuklaayush merged commit 2eb1b79 into Citadel-DAO:main May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sajanrajdev sajanrajdev sajanrajdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brianendo @shuklaayush @sajanrajdev