typified p-u

[PatrikLundell]

Summary

None

Purpose of change

Replace usage of untyped coordinates with typed ones. This time files in the range t - u.

Describe the solution

• Get rid of the now unused pos() operation from the talker class hierarchy.
• Identify what the coordinates of untyped coordinates are and change them to those coordinates, adjusting usage accordingly.
• Gotten rid of some redundant casting of coordinates to the type they already belong to.
• Gotten rid of an unused structure using untyped coordinates rather than trying to guess what usage the author might have intended for it.

Describe alternatives you've considered

Testing

Load save, walk up ramp, jump into car, drive through hay bales, run over zombie corpse with inventory, run over a turkey, smash into stationary vehicle.

Additional context

[GuardianDll]

Resolve clang-tidy errors please

[PatrikLundell]

I can't, at least not without guidance,..

One of the errors is a comment someone made (and I've seen the errors on previous PRs as well), and it seems to be related to translation directives somehow. I have no idea how to deal with that is a sensible manner (I can remove the '~' character that seems to trigger the test or remove the comment completely, but I guess it was placed there for a reason).

The other one is something about uncrafting not meeting some expectations, and, again, I don't know what's supposed to be done (but I haven't looked at the test code).

[GuardianDll]

i suspect you just need to swap 3848 and 3849; not sure why only your PR shows it as an error tho, don't remember seeing this error anywhere else

[GuardianDll]

well, here is our answer #79394, it seems it should be within the function
anyway we just gonna ignore erroring clang for this PR, since none of errors are actually related to typification

[PatrikLundell]

Good. Turns out my guess was correct, which means the easiest is probably to accept this PR is it's current state and scrub #79394, as this PR now includes the #79394 solution.

The complaint was probably caused by #79336, which probably caused the line to get long enough to have astyle break it.

However, this reveals a deficiency in the test and/or translation support: It ought to have the flexibility to allow the comments placed above the operation the string is included in, rather than require a placement directly above the string, for two reasons:

• Placement within the operation clutters it, making it harder to read.
• Astyle can disrupt the connection without any active involvement from the programmer.